Re: [Xen-devel] Proposal: vif-local

["W. Michael Petullo" <mike@xxxxxxxx>]

>> I have attached a patch against Xen 4.1.0 that implements a vif-post.d
>> system. I only support the Linux hotplug case at this point.
 
> The header of "${XEN_SCRIPT_DIR}/vif-post.d/00-vif-local" describes a
> command line parameter "(add|remove|online|offline)" but none of the
> invocations actually pass one.

Since the hooks are now sourced they no longer take parameters. It is,
in fact, a shell variable and I have updated the comments.

> I think it would be better to encapsulate the functionality in a
> "call_hooks <devtype> <hook> <other args...>" function in
> xen-hotplug-common.sh, calling it as "call_hooks vif post ..." rather
> than open coding that loop everywhere.

Good idea. Implemented.
 
> I think generally it is a good idea to have an explicit suffix (e.g.
> ".hook") for this sort of thing since then you can use *.hook to get the
> list of files which saves manually filtering out *~ *.rpmsave *.dpkg-bak
> *.disabled-by-admin *.some-random-suffix-intended-to-disable-the-script
> etc.

Implemented.
 
> You probably want to quote $f in case some nutter uses a space in the
> hook filename.

Implemented.
 
> You don't actually install 00-vif-local but I think that's a good thing
> since the default is an empty script so we save a fork/exec by not
> running it.

Good.
 
> Lastly we need a Signed-off-by per the DCO (section 11 of
> http://lwn.net/Articles/139918/) as well as a suitable changelog message
> before we can apply any patch.

Please see the attached patch.

Allow for site-specific hooks that will be executed after Xen initializes
a vif. This allows an administrator to specify custom firewall rules or
other special configuration parameters.

Signed-off-by: W. Michael Petullo <mike@xxxxxxxx>

-- 
Mike

:wq

xen-4.1.0-local-vif-scripts-1.patch
Description: Text document

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel