|  |  | 
  
    |  |  | 
 
  |   |  | 
  
    |  |  | 
  
    |  |  | 
  
    |   xen-devel
[Xen-devel] Re: [PATCH 4/4] mm: Do not define PFN_SECTION_SHIFT if !CONF 
| To: | Daniel Kiper <dkiper@xxxxxxxxxxxx> |  
| Subject: | [Xen-devel] Re: [PATCH 4/4] mm: Do not define PFN_SECTION_SHIFT if !CONFIG_SPARSEMEM |  
| From: | Dave Hansen <dave@xxxxxxxxxxxxxxxxxx> |  
| Date: | Tue, 03 May 2011 09:10:12 -0700 |  
| Cc: | jeremy@xxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx, ian.campbell@xxxxxxxxxx,	haicheng.li@xxxxxxxxxxxxxxx, konrad.wilk@xxxxxxxxxx,	dan.magenheimer@xxxxxxxxxx, v.tolstov@xxxxxxxxx,	linux-kernel@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx,	rientjes@xxxxxxxxxx, andi.kleen@xxxxxxxxx,	akpm@xxxxxxxxxxxxxxxxxxxx, fengguang.wu@xxxxxxxxx, wdauchy@xxxxxxxxx |  
| Delivery-date: | Tue, 03 May 2011 09:11:46 -0700 |  
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |  
| In-reply-to: | <20110502212226.GE4623@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> |  
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |  
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |  
| List-post: | <mailto:xen-devel@lists.xensource.com> |  
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>,	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |  
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>,	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |  
| References: | <20110502212226.GE4623@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> |  
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |  
| On Mon, 2011-05-02 at 23:22 +0200, Daniel Kiper wrote:
> Do not define PFN_SECTION_SHIFT if !CONFIG_SPARSEMEM.
> 
> Signed-off-by: Daniel Kiper <dkiper@xxxxxxxxxxxx> 
I'd like if this was a bit easier to verify that it didn't break
anything.  Basically, we should probably limit direct use of
PFN_SECTION_SHIFT to inside #ifdefs in headers.
But, if something is truly using this today, it's probably broken.  It's
easy enough to work around if someone hits it, I guess.
Acked-by: Dave Hansen <dave@xxxxxxxxxxxxxxxxxx>
-- Dave
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
 | 
 |  | 
  
    |  |  |