WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [PATCH 16 of 24] tools: ocaml: rename the device_build_state

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] [PATCH 16 of 24] tools: ocaml: rename the device_build_state types and functions
From: Ian Campbell <ian.campbell@xxxxxxxxxx>
Date: Wed, 13 Apr 2011 15:36:57 +0100
Cc: Vincent Hanquez <Vincent.Hanquez@xxxxxxxxxxxxx>, Dave Scott <Dave.Scott@xxxxxxxxxxxxx>
Delivery-date: Wed, 13 Apr 2011 07:55:58 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <patchbomb.1302705401@xxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <patchbomb.1302705401@xxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mercurial-patchbomb/1.6.4
# HG changeset patch
# User David Scott <dave.scott@xxxxxxxxxxxxx>
# Date 1301507668 -3600
# Node ID 27ae89234b2a3eb2f5da96b1efd8578bef608fdb
# Parent  d4357ab0e6b41ac8b89e5ec658c464ace23534b6
tools: ocaml: rename the device_build_state types and functions

The aims are:
1. make the records instantiable if they have field names in common; and
2. to make it easier to derive the names programatically from the IDL

Signed-off-by: David Scott <dave.scott@xxxxxxxxxxxxx>
Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

diff -r d4357ab0e6b4 -r 27ae89234b2a tools/ocaml/libs/xl/xl.ml
--- a/tools/ocaml/libs/xl/xl.ml Wed Mar 30 18:54:28 2011 +0100
+++ b/tools/ocaml/libs/xl/xl.ml Wed Mar 30 18:54:28 2011 +0100
@@ -70,13 +70,15 @@ module Domain_build_info = struct
        }
 end
 
-type build_state =
-{
-       store_port : int;
-       store_mfn : int64;
-       console_port : int;
-       console_mfn : int64;
-}
+module Device_build_state = struct
+       type t =
+       {
+               store_port : int;
+               store_mfn : int64;
+               console_port : int;
+               console_mfn : int64;
+       }
+end
 
 type domid = int
 
@@ -137,7 +139,7 @@ module Device_console = struct
                consoletype : console_type;
        }
 
-       external add : t -> build_state -> domid -> unit = 
"stub_xl_device_console_add"
+       external add : t -> Device_build_state.t -> domid -> unit = 
"stub_xl_device_console_add"
 end
 
 module Device_vkb = struct
diff -r d4357ab0e6b4 -r 27ae89234b2a tools/ocaml/libs/xl/xl.mli
--- a/tools/ocaml/libs/xl/xl.mli        Wed Mar 30 18:54:28 2011 +0100
+++ b/tools/ocaml/libs/xl/xl.mli        Wed Mar 30 18:54:28 2011 +0100
@@ -70,13 +70,15 @@ module Domain_build_info : sig
        }
 end
 
-type build_state =
-{
-       store_port : int;
-       store_mfn : int64;
-       console_port : int;
-       console_mfn : int64;
-}
+module Device_build_state : sig
+       type t =
+       {
+               store_port : int;
+               store_mfn : int64;
+               console_port : int;
+               console_mfn : int64;
+       }
+end
 
 type domid = int
 
@@ -137,7 +139,7 @@ module Device_console : sig
                consoletype : console_type;
        }
 
-       external add : t -> build_state -> domid -> unit = 
"stub_xl_device_console_add"
+       external add : t -> Device_build_state.t -> domid -> unit = 
"stub_xl_device_console_add"
 end
 
 module Device_vkb : sig

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>