|
xen-devel
Re: [Xen-devel] Re: [PATCH] xen: drop anti-dependency on X86_VISWS
|
To: |
Jeremy Fitzhardinge <jeremy@xxxxxxxx> |
|
Subject: |
Re: [Xen-devel] Re: [PATCH] xen: drop anti-dependency on X86_VISWS |
|
From: |
Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx> |
|
Date: |
Sat, 9 Apr 2011 11:34:52 +0100 |
|
Cc: |
"randy.dunlap@xxxxxxxxxx" <randy.dunlap@xxxxxxxxxx>, Jeremy Fitzhardinge <Jeremy.Fitzhardinge@xxxxxxxxxx>, "eric.dumazet@xxxxxxxxx" <eric.dumazet@xxxxxxxxx>, "konrad.wilk@xxxxxxxxxx" <konrad.wilk@xxxxxxxxxx>, Miller <davem@xxxxxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxxxx>, "virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx" <virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx>, "mingo@xxxxxxxxxx" <mingo@xxxxxxxxxx>, "hpa@xxxxxxxxx" <hpa@xxxxxxxxx>, "tglx@xxxxxxxxxxxxx" <tglx@xxxxxxxxxxxxx>, "mirq-linux@xxxxxxxxxxxx" <mirq-linux@xxxxxxxxxxxx>, "pazke@xxxxxxxxx" <pazke@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, David |
|
Delivery-date: |
Sat, 09 Apr 2011 03:35:52 -0700 |
|
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxxx |
|
In-reply-to: |
<4D9F52D4.6030700@xxxxxxxx> |
|
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
|
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
|
List-post: |
<mailto:xen-devel@lists.xensource.com> |
|
List-subscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
|
List-unsubscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
|
Organization: |
Citrix Systems, Inc. |
|
References: |
<1301828839.2837.143.camel@edumazet-laptop> <20110403.172407.91341067.davem@xxxxxxxxxxxxx> <1301910955.23887.75.camel@xxxxxxxxxxxxxxxxxxxxxx> <20110406.144515.235693855.davem@xxxxxxxxxxxxx> <1302159483.31620.36.camel@xxxxxxxxxxxxxxxxxxxxx> <4D9DFD6A.1060200@xxxxxxxx> <1302244694.31620.44.camel@xxxxxxxxxxxxxxxxxxxxx> <4D9F28FE.9000803@xxxxxxxx> <4D9F48E8020000780003AA48@xxxxxxxxxxxxxxxxxx> <4D9F52D4.6030700@xxxxxxxx> |
|
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
On Fri, 2011-04-08 at 11:24 -0700, Jeremy Fitzhardinge wrote:
> On 04/08/2011 08:42 AM, Jan Beulich wrote:
> >>>> On 08.04.11 at 17:25, Jeremy Fitzhardinge <jeremy@xxxxxxxx> wrote:
> >> On 04/07/2011 11:38 PM, Ian Campbell wrote:
> >>> Is there any downside to this patch (is X86_CMPXCHG in the same sort of
> >>> boat?)
> >> Only if we don't use cmpxchg in shared memory with other domains or the
> >> hypervisor. (I don't think it will dynamically switch between real and
> >> emulated cmpxchg depending on availability.)
We do use cmpxchg in the grant table code at least (actually,
sync_cmpxchng in that case).
> > Actually it does - see the "#ifndef CONFIG_X86_CMPXCHG" section
> > in asm/cmpxchg_32.h.
>
> Hm, OK. Still, I'm happiest with that dependency in case someone
> knobbles the cpu to exclude cmpxchg and breaks things.
Dropping the TSC patch is sensible though?
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
Home