Re: [Xen-devel] arch_set_info_guest() producing inconsistent sta

To:	Jan Beulich <JBeulich@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject:	Re: [Xen-devel] arch_set_info_guest() producing inconsistent state on x86?
From:	Keir Fraser <keir.xen@xxxxxxxxx>
Date:	Tue, 29 Mar 2011 13:01:28 +0100
Cc:
Delivery-date:	Tue, 29 Mar 2011 05:03:37 -0700
Dkim-signature:	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:user-agent:date:subject:from:to:message-id :thread-topic:thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; bh=kOUbcpimFghjCm5X+S9b2DMO+WYbihkEazYMoYIAOAA=; b=c46cGgDjcpJKnuxenqrraJjXkDQrpG4st5qlsmsMSELGYKGdMVf+e1D6g8/CFFm1u/ snOEmW0CfAn531NBZGZk4DHlShDMP6g0hckPX2sXAiTuocdwPyQmhOIV8fwWdvo2IcOU ORcWy6RJd2BIp2HsrK2HgLvsyR5JV3IG3c17k=
Domainkey-signature:	a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=user-agent:date:subject:from:to:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=h0iXSWWTnhia1tlbEKwQIrJw2eb7aTHRD5TLlIhDfRwTSYWiJw2PQwnzx1aif4qR7g Sytyp0Yy67Imqf/rxXrASqg2DuQAX7Um5upoG0pNqfInSQfuBck2hckRfBGzcjJkgmqJ E7xVSmgGbi//iV+rCPuXzvNGN9OXMVtoXyBrc=
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<4D91E2820200007800038D68@xxxxxxxxxxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index:	AcvuCQjN5ctjchqMEk+IlJPZ/C/M3w==
Thread-topic:	[Xen-devel] arch_set_info_guest() producing inconsistent state on x86?
User-agent:	Microsoft-Entourage/12.28.0.101117

On 29/03/2011 12:45, "Jan Beulich" <JBeulich@xxxxxxxxxx> wrote:

>> It's probably used by debuggers running in dom0? Also see
>> modify_returncode() in libxc/xc_resume.c -- so it's used on suspend resume
>> in the failure case.
>> 
>> I doubt anything other than GPRs are ever modified after first
>> initialisation.
> 
> So should we then perhaps make the function check the bits
> it doesn't really update match what is in place already?

I suppose it would be nice. I can't say I care much one way or the other.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

WARNING - OLD ARCHIVES

xen-devel

Re: [Xen-devel] arch_set_info_guest() producing inconsistent state on x8