| |
|
 |
|
 |
|
|
|
| |
|
|
xen-devel
[Xen-devel] Re: [RFC PATCH V4 3/5] cpuidle: default idle driver for x86
|
To: |
Trinabh Gupta <trinabh@xxxxxxxxxxxxxxxxxx> |
|
Subject: |
[Xen-devel] Re: [RFC PATCH V4 3/5] cpuidle: default idle driver for x86 |
|
From: |
Vaidyanathan Srinivasan <svaidy@xxxxxxxxxxxxxxxxxx> |
|
Date: |
Thu, 24 Mar 2011 22:02:20 +0530 |
|
Cc: |
venki@xxxxxxxxxx, ak@xxxxxxxxxxxxxxx, suresh.b.siddha@xxxxxxxxx, sfr@xxxxxxxxxxxxxxxx, peterz@xxxxxxxxxxxxx, benh@xxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx, arjan@xxxxxxxxxxxxxxx, Len Brown <lenb@xxxxxxxxxx> |
|
Delivery-date: |
Thu, 24 Mar 2011 17:13:30 -0700 |
|
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxxx |
|
In-reply-to: |
<4D89BDE2.9040606@xxxxxxxxxxxxxxxxxx> |
|
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
|
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
|
List-post: |
<mailto:xen-devel@lists.xensource.com> |
|
List-subscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
|
List-unsubscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
|
References: |
<20110322123208.28725.30945.stgit@xxxxxxxxxxxxxxxxxxx> <20110322123244.28725.32435.stgit@xxxxxxxxxxxxxxxxxxx> <alpine.LFD.2.02.1103222304300.10549@x980> <4D89BDE2.9040606@xxxxxxxxxxxxxxxxxx> |
|
Reply-to: |
svaidy@xxxxxxxxxxxxxxxxxx |
|
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
|
User-agent: |
Mutt/1.5.20 (2009-06-14) |
* Trinabh Gupta <trinabh@xxxxxxxxxxxxxxxxxx> [2011-03-23 15:01:14]:
>
> On 03/23/2011 08:43 AM, Len Brown wrote:
> >Why is this patch a step forward?
>
> Hi Len,
>
> I have basically moved the code for arch default and mwait
> idle from arch/x86/kernel/process.c to a driver. This was
> suggested by Venki (https://lkml.org/lkml/2010/10/19/460)
> as part of pm_idle cleanup and direct call of
> cpuidle_idle_call(). There is not much new code here.
>
> >
> >>+obj-$(CONFIG_X86) += default_driver.o
> >
> >BTW, that's a pretty generic name for an x86 specific idle driver...
> >
> >I think that on builds that support intel_idle and acpi_idle,
> >everything in this file will be unused, unless somebody uses some
> >debugging cmdline params that should have been deleted ages ago.
>
> Yes, I agree that the name has to be x86 specific. I think the
> routines would be used for pre-nehalem architectures that use
> arch default or mwait.
Mainly selection between default_idle (safe_halt), mwait_idle and
c1e_idle needs to be placed in a default driver. This is the code
that was 'outside' of cpuidle framework and directly used pm_idle().
This is mostly unused and overridden by intel_idle or acpi_idle, but
still cannot be discarded.
Maybe keep this as a module and probe/load only if both intel_idle and
acpi_idle failed to load or excluded by command line or otherwise.
--Vaidy
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
| |
|
Home