WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 2/12] VTPM mini-os: posix IO layer for blkfront i

To: Matthew Fioravante <matthew.fioravante@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 2/12] VTPM mini-os: posix IO layer for blkfront in mini-os
From: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>
Date: Mon, 14 Mar 2011 22:43:05 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Mon, 14 Mar 2011 14:43:42 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4D7E896F.2080209@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Mail-followup-to: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>, Matthew Fioravante <matthew.fioravante@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
References: <4D7AA372.4040506@xxxxxxxxxx> <20110312010526.GK4922@xxxxxxxxxxxxxxxxxxxxxxxxx> <4D7E6772.2040606@xxxxxxxxxx> <20110314192945.GG4370@xxxxxxxxxxxxxxxxxxxxxxxxx> <4D7E896F.2080209@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.12-2006-07-14
Matthew Fioravante, le Mon 14 Mar 2011 17:32:31 -0400, a écrit :
> >>>>+     aiocb.aio_cb = NULL;
> >>>Maybe blkfront_aio_cb should do it itself?  It looks odd to have to do
> >>>it when reusing an aiocb structure.
> >>>
> I think I totally misunderstood you. With the last case are you just 
> referring to how I keep having to set the callback to NULL everytime?

Yes.

> If so I totally agree with you. It should just set it back to NULL
> when its done.
> 
> I thought you were talking about how I was handling writes to partial 
> blocks and that somehow the low level blkfront functions should be doing 
> this transparently.

Nope.

Samuel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel