WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH]: Allow tools to map arbitrarily large machphys_m

To: Gianni Tedesco <gianni.tedesco@xxxxxxxxxx>, Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH]: Allow tools to map arbitrarily large machphys_mfn_list on 32bit dom0
From: Keir Fraser <keir.xen@xxxxxxxxx>
Date: Mon, 14 Mar 2011 15:08:57 +0000
Cc: Tim Deegan <Tim.Deegan@xxxxxxxxxxxxx>, Xen Devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxxxx>
Delivery-date: Mon, 14 Mar 2011 08:09:36 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:user-agent:date:subject:from:to:cc:message-id :thread-topic:thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; bh=ob/Pcuid2yY37yOCrn1+12FYsP3DyCgWOIeH8Txjb/s=; b=ADkXMxgR9Cl9foFtYi3eRzCWdikyX6hdNVwYyyt+RyYYSlr4nS/aUuuKrlWC/WN/pi zA2KQ+Lt9IY0JQGLMX4h73Ao/FGCSHnOz6AH1CpNndcI68SQOKpfdBsc5YL4dVJcHLhl AoDym+8g62yrT7hC4kA3BjV2xZb1Vmof28Hi4=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=user-agent:date:subject:from:to:cc:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=J/rZN4ANv32/NkX76Dzq5wpWlBw9JnV7vREgRno7i6TDqZHfAcI380YJlto1hg/Iu3 ujckRYbfOgf7m6/qzuqsIYlWMzmQs8W+crytdy3AdZDjVq/kxLDP2qxAEB6PjQ9+tuv5 SYJKIYnuemlSadXKh5e/iKd11ToqCLH0bUYLI=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1300115112.17229.78.camel@xxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcviWb2IoLCXGJ7Bt02qiI9imDOPiA==
Thread-topic: [PATCH]: Allow tools to map arbitrarily large machphys_mfn_list on 32bit dom0
User-agent: Microsoft-Entourage/12.28.0.101117
Cc'ing Jan. I'd appreciate his Ack as this is his code originally. I don't
think we're missing anything subtle though.

 -- Keir

On 14/03/2011 15:05, "Gianni Tedesco" <gianni.tedesco@xxxxxxxxxx> wrote:

> This permits suspend/resume to work with 32bit dom0/tools. AFAICT the
> limit to MACH2PHYS_COMPAT_NR_ENTRIES is redundant since that refers to a
> limit in kernel mappings under 32bit hypervisors, not userspace where
> there may be gigabytes of useful virtual space for this.
> 
> Suggested-by: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>
> Signed-off-by: Gianni Tedesco <gianni.tedesco@xxxxxxxxxx>
> 
> diff -r cf558cb8b92b xen/arch/x86/x86_64/compat/mm.c
> --- a/xen/arch/x86/x86_64/compat/mm.c Mon Mar 07 17:52:44 2011 +0000
> +++ b/xen/arch/x86/x86_64/compat/mm.c Mon Mar 14 14:58:04 2011 +0000
> @@ -162,8 +162,7 @@ int compat_arch_memory_op(int op, XEN_GU
>              return -EFAULT;
>  
>          limit = (unsigned long)(compat_machine_to_phys_mapping +
> -            min_t(unsigned long, max_page,
> -                  MACH2PHYS_COMPAT_NR_ENTRIES(current->domain)));
> +                    (unsigned long)max_page);
>          if ( limit > RDWR_COMPAT_MPT_VIRT_END )
>              limit = RDWR_COMPAT_MPT_VIRT_END;
>          for ( i = 0, v = RDWR_COMPAT_MPT_VIRT_START, last_mfn = 0;
> 
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>