WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] bogus HPET initialization order on x86

To: Jan Beulich <JBeulich@xxxxxxxxxx>
Subject: RE: [Xen-devel] bogus HPET initialization order on x86
From: "Wei, Gang" <gang.wei@xxxxxxxxx>
Date: Fri, 11 Mar 2011 17:49:52 +0800
Accept-language: zh-CN, en-US
Acceptlanguage: zh-CN, en-US
Cc: Keir Fraser <keir.xen@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, "Yu, Ke" <ke.yu@xxxxxxxxx>, "Wei, Gang" <gang.wei@xxxxxxxxx>
Delivery-date: Fri, 11 Mar 2011 01:50:52 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4D79EA5A0200007800035BF4@xxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4D77A07D020000780003593A@xxxxxxxxxxxxxxxxxx> <4D77A43A0200007800035980@xxxxxxxxxxxxxxxxxx> <F26D193E20BBDC42A43B611D1BDEDE7125F780036E@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <4D79EA5A0200007800035BF4@xxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcvfxaoZr2Qt+LnaTYmPKA6Fe7RpNgAC0i7g
Thread-topic: [Xen-devel] bogus HPET initialization order on x86
Jan Beulich wrote on 2011-03-11:
>>>> On 10.03.11 at 04:35, "Wei, Gang" <gang.wei@xxxxxxxxx> wrote:
>> Jan Beulich wrote on 2011-03-09:
>>> Also, what's the point of decrementing the per-CPU irq_count in
>>> hpet_legacy_irq_tick()?
>> 
>> The per-CPU irq_count are used for calculate the total irq number
>> excluding hpet irqs in a past period to give a estimation of IO
>> frequence. The hpet irq was counted in do_IRQ, so need to reduce it
>> while handling it. You can see another one in hpet_interrupt_handler().
> 
> I can understand the latter, but the one I was asking about decrements
> irq_count even if not calling the event handler (i.e.
> when returning zero from the function). In other words, I would have
> understood what this is for if it was sitting after the initial if().

The irq_count is added to count the total irq number excluding hpet/pit irqs, 
so even the real event handler was not called, the adjustment should still be 
done.

Jimmy



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel