WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 2/3] add DomU xz kernel decompression

To: "Jan Beulich" <JBeulich@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 2/3] add DomU xz kernel decompression
From: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Date: Thu, 10 Mar 2011 17:51:08 +0000
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Thu, 10 Mar 2011 09:51:48 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4D776EA802000078000357A8@xxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Newsgroups: chiark.mail.xen.devel
References: <4D776EA802000078000357A8@xxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Jan Beulich writes ("[Xen-devel] [PATCH 2/3] add DomU xz kernel decompression"):
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>

I see this has already been committed, but:

> --- a/tools/libxc/xc_dom_bzimageloader.c
> +++ b/tools/libxc/xc_dom_bzimageloader.c
...
>  {
> -    lzma_stream stream = LZMA_STREAM_INIT;
> -    lzma_ret ret;
>      lzma_action action = LZMA_RUN;
>      unsigned char *out_buf;
>      unsigned char *tmp_buf;
> @@ -152,10 +151,9 @@ static int xc_try_lzma_decode(
>      int outsize;
>      const char *msg;
>  
> -    ret = lzma_alone_decoder(&stream, 128*1024*1024);
>      if ( ret != LZMA_OK )
>      {

I don't think this can possibly be correct.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel