WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH pvops] Fix a bug that shutdown watcher is disable

To: Frank Pan <frankpzh@xxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH pvops] Fix a bug that shutdown watcher is disabled on pvops
From: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Date: Thu, 3 Mar 2011 13:29:09 -0500
Cc: Ian Campbell <Ian.Campbell@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx, Jeremy Fitzhardinge <Jeremy.Fitzhardinge@xxxxxxxxxx>, Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Delivery-date: Thu, 03 Mar 2011 10:31:22 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <AANLkTikUyYpVKG_LZHFLL-ziCfU-Oc3qM9uFCd7QH13Z@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <AANLkTikUyYpVKG_LZHFLL-ziCfU-Oc3qM9uFCd7QH13Z@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.20 (2009-06-14)
On Fri, Mar 04, 2011 at 12:46:20AM +0800, Frank Pan wrote:
> I use pvops kernel for HVM domU, and I find that shutdown watcher is

Which one? 2.6.32? stock 2.6.37? devel 2.6.38?
> not enabled at all when I compile platform-pci module inside kernel.
> The code related calls xen_setup_shutdown_event after xenbus_probe,
> that makes setup_shutdown_watcher never called.
> 
> The following patch fixes this by changing the order of xenbus_probe
> and xen_setup_shutdown, which makes my PV-on-HVM domU responses well
> for the "control/shutdown" entry.
> 
> ---
>  linux-2.6-xen/drivers/xen/platform-pci.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/linux-2.6-xen/drivers/xen/platform-pci.c
> b/linux-2.6-xen/drivers/xen/platform-pci.c
> index c01b5dd..f141cfe 100644
> --- a/linux-2.6-xen/drivers/xen/platform-pci.c
> +++ b/linux-2.6-xen/drivers/xen/platform-pci.c
> @@ -162,10 +162,10 @@ static int __devinit platform_pci_init(struct
> pci_dev *pdev,
>       ret = gnttab_init();
>       if (ret)
>               goto out;
> -     xenbus_probe(NULL);
>       ret = xen_setup_shutdown_event();
>       if (ret)
>               goto out;
> +     xenbus_probe(NULL);
>       return 0;
> 
>  out:
> -- 
> 1.7.0.4
> 
> -- 
> Frank Pan
> 
> Computer Science and Technology
> Tsinghua University

> From 8d2402bd48ccc9eb5afe2aaa407d61ff715cb24c Mon Sep 17 00:00:00 2001
> From: Frank Pan <frankpzh@xxxxxxxxx>
> Date: Thu, 3 Mar 2011 16:36:17 +0000
> Subject: [PATCH] Fix a bug that shutdown watcher is disabled on pvops
> 
> ---
>  linux-2.6-xen/drivers/xen/platform-pci.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/linux-2.6-xen/drivers/xen/platform-pci.c 
> b/linux-2.6-xen/drivers/xen/platform-pci.c
> index c01b5dd..f141cfe 100644
> --- a/linux-2.6-xen/drivers/xen/platform-pci.c
> +++ b/linux-2.6-xen/drivers/xen/platform-pci.c
> @@ -162,10 +162,10 @@ static int __devinit platform_pci_init(struct pci_dev 
> *pdev,
>       ret = gnttab_init();
>       if (ret)
>               goto out;
> -     xenbus_probe(NULL);
>       ret = xen_setup_shutdown_event();
>       if (ret)
>               goto out;
> +     xenbus_probe(NULL);
>       return 0;
>  
>  out:
> -- 
> 1.7.0.4
> 

> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel