Re: [xen-devel][PATCH 2/5] Xl interface change plus changes to code it impacts

[Kamala Narasimhan <kamala.narasimhan@xxxxxxxxx>]

Ian Jackson wrote:
> Kamala Narasimhan writes ("Re: [xen-devel][PATCH 2/5] Xl interface change 
> plus changes to code it impacts"):
>> Attached patch should address your concerns.
> 
> Thanks for this.  However, there were other changes made between
> this most recent version and the previous version, besides the ones
> I mentioned in my comments and which you said you'd address.
> 
> When you post an updated version of a patch you should state
> separately
>  - what the patch does to the tree, including intended changes,
>    motivation, etc., as you have done (for the commit message)
>  - how the patch differs from the previous version, if applicable
> 
> Can you explain what the changes you made and why you made them ?
> Ideally in general you should use revision control system tools to
> make sure that you know what they all are.
> 
> But, for your info here is the output of
>   diff -w --exclude=\*{~,.o,.d,.opic} -ru A B |grep -v '^Only in'
> 
> Most of this is formatting noise, which addresses my comments.
> 
> However, you have also:
>   * Initialised disk->format and disk->backend somewhere you
>     previously didn't
>   * Recognised the "tap2" prefix in a place you previously didn't
>   * Changed the handling of the "aio" and "raw" prefixes
>
Yes, they are all changes made based on input from Stefano and in an attempt to
be in sync with the documentation.  Ideally we wouldn't need these changes if we
were to go with the rest of the patches but since we made a decision not to go
with the rest before 4.2, we decided to do some minimal changes to sync with the
doc.

> Normally patch such as this one, which is presented as being mature,
> ought not to need unexplained semantic changes at this late stage.
I think we are beating to death an already dull set of changes which makes it
all the more uninteresting to me :)  But I digress...

Just to be clear - Would you accept the patch I sent earlier if I extended the
description to include the fact that I initialize disk format, backend to
default values and changed how we handle "aio" prefix plus recognize "raw" and
"tap2" prefixes now?

Kamala



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel