WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Build errors with latest xen-unstable from staging

To: Andre Przywara <andre.przywara@xxxxxxx>
Subject: Re: [Xen-devel] Build errors with latest xen-unstable from staging
From: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Date: Mon, 7 Feb 2011 17:03:28 +0000
Cc: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>, Kamala Narasimhan <kamala.narasimhan@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Mon, 07 Feb 2011 09:04:18 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4D50041C.5060907@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Newsgroups: chiark.mail.xen.devel
References: <4D4EF01F.5050106@xxxxxxxxx> <1297072022.13091.753.camel@xxxxxxxxxxxxxxxxxxxxxx> <4D50041C.5060907@xxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Andre Przywara writes ("Re: [Xen-devel] Build errors with latest xen-unstable 
from staging"):
> > On Sun, 2011-02-06 at 19:01 +0000, Kamala Narasimhan wrote:
> >> GCC version - 4.2.4.  Initializing the three variables it complained about 
> >> fixed
> >> the issue.

Thanks for the patch.

> To appease the compiler I would ack the fix, though from an academic 
> point of view it is not necessary.

Yes, thanks, I have applied it.

> I don't think so. x = x looks more like a hack, if we can easily 
> initialize the variables, we should do so.

Quite so.

> >>   If this trivial change should require a signed off line, here it is
> >> - Signed-off-by: Kamala Narasimhan <kamala.narasimhan@xxxxxxxxxx>
> > 
> > Always just assume a change does.

Indeed.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>