WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: Avoid alloc for xsave before xsave_init

To: "Wei, Gang" <gang.wei@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] Re: Avoid alloc for xsave before xsave_init
From: Keir Fraser <keir@xxxxxxx>
Date: Thu, 13 Jan 2011 21:13:09 +0000
Cc:
Delivery-date: Thu, 13 Jan 2011 13:14:18 -0800
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:sender:user-agent:date:subject:from:to :message-id:thread-topic:thread-index:in-reply-to:mime-version :content-type:content-transfer-encoding; bh=lMl7v82ubGitJ0vXghEWRLzjP/CvSPpE08gqSLvmacA=; b=RgvQHIHOtcNdsWi6EuTSJ+geDWbMNFpIuHqpjmk5wc3QMwSJIgkMlscLDeayVBqQck WRklj8ars/JcU6QJOMkiKD3FuPq5a7Hu3UGb9oWCHwz4NTzFzzT+ILLsqGwVOQYMTXoK e6C24kzrWS2PvtG7tl4+yuTa8N2hrNzfkiFDo=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:user-agent:date:subject:from:to:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=eNkGr8bRKwCtwevdC0JC/yFccSh0Mr2XEVLIPBBxIzr/xlWh4VU0Zoxq9707U6jt1S bWRVolTzLcNhL53eLMYQYSqjYvfDp3l1s7xA+OOgUtgyz1qhay6FGhuaxu40xg18O9QD SL1abIYw+zzzJVjCxkLRxEky+8maNKD6xJiWw=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <F26D193E20BBDC42A43B611D1BDEDE7125198A82D9@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcuzUojLeS2z6tQSQCO88b+hMX2tAQAFCTB3
Thread-topic: Avoid alloc for xsave before xsave_init
User-agent: Microsoft-Entourage/12.28.0.101117
On 13/01/2011 18:48, "Wei, Gang" <gang.wei@xxxxxxxxx> wrote:

> While debugging some weird booting failure bugs, just found currently,
> xsave_alloc_save_area will be called in
> init_idle_domain->scheduler_init->alloc_vcpu->vcpu_initialise calls, it is
> earlier than xsave_init called in identity_cpu(). This may causing buffer
> overflow on xmem_pool. I am thinking about how to fix it.

I doubt idle vcpus need an xsave context. Can we check for is_idle_vcpu() in
xsave_{alloc,free}_save_area()?

Is this an issue only for xen-unstable/4.1 (not 4.0)?

 -- Keir

> Jimmy



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel