Re: [Xen-devel] [PATCH] xl: save domain config (userdata) under correct domid/uuid

[Gianni Tedesco <gianni.tedesco@xxxxxxxxxx>]

On Thu, 2011-01-13 at 00:20 +0000, Ian Jackson wrote:
> The automatic tests write:
> > Regressions :-(
> > 
> > Tests which did not succeed and are blocking:
> >  test-amd64-amd64-xl          11 guest-localmigrate         fail REGR. vs. 
> > 4586
> [etc]
> 
> I think this is fixed by the patch below, which I have just applied.
> 
> Ian.
> 
> # HG changeset patch
> # User Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
> # Date 1294877915 0
> # Node ID d839631b604807fe0f978f9eacc1c73f6a9bf0bd
> # Parent  20b0f709153e9e36c937caae8ec0b816c8ad1cfd
> xl: save domain config (userdata) under correct domid/uuid
> 
> Recent changes caused the domain config file to be saved under dom0's
> filename in /var/lib/xen.  This was due to the config file being saved
> before the domain was created and thus before the domid and uuid were
> known.
> 
> Fix this by moving the saving code to after creation.
> 
> Also, change the "default" initialisation of domid in
> xl_cmdimpl.c:create_domain to be domid=-1.  That provides a more
> obviously wrong value than 0 (which refers to dom0) so that other bugs
> of this kind would be more likely to show up.
> 
> Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> Tested-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

Nice catch, thanks. It's still a beast of a function.

Gianni


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel