WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 2 of 4] xl: Introduce libxl_domain_create_new() a

To: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 2 of 4] xl: Introduce libxl_domain_create_new() and libxl_domain_create_restore()
From: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Date: Thu, 6 Jan 2011 19:34:37 +0000
Cc: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Gianni Tedesco <gianni.tedesco@xxxxxxxxxx>, Stefano Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>
Delivery-date: Thu, 06 Jan 2011 11:34:06 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <19750.723.163429.549792@xxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <patchbomb.1294234912@xxxxxxxxxxxxxxxxxxxxxxx> <c6e3c9a8029db76295c5.1294234914@xxxxxxxxxxxxxxxxxxxxxxx> <19750.723.163429.549792@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Alpine 2.00 (DEB 1167 2008-08-23)
On Thu, 6 Jan 2011, Ian Jackson wrote:
> Gianni Tedesco writes ("[Xen-devel] [PATCH 2 of 4] xl: Introduce 
> libxl_domain_create_new() and libxl_domain_create_restore()"):
> > xl: Introduce libxl_domain_create_new() and libxl_domain_create_restore()
> 
> This patch looks reasonable to me - at least, the API seems sensible
> to me.  I didn't diff all of the shuffled-about code :-).
> 
> I'll wait for an ack from Stefano too though.
 
Thanks.

I think the patch is overall correct but please make sure to test it
with stubdoms at least once.
Also I think we need to move all the init_*_info functions to libxl too,
in order to provide sensible defaults for libxl_domain_config *d_config.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>