WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH][TOOLS] libxl: open code basename()

To: Juergen Gross <juergen.gross@xxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH][TOOLS] libxl: open code basename()
From: Christoph Egger <Christoph.Egger@xxxxxxx>
Date: Wed, 15 Dec 2010 13:38:36 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 15 Dec 2010 04:39:58 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4D08B35A.7060200@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <201012151312.59779.Christoph.Egger@xxxxxxx> <4D08B35A.7060200@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: KMail/1.9.10
On Wednesday 15 December 2010 13:23:54 Juergen Gross wrote:
> On 12/15/10 13:12, Christoph Egger wrote:
> > Hi!
> >
> > Attached patch open codes basename() with strrchr().
> > Fixes build on platforms like NetBSD where POSIX basename is available.
> >
> > Signed-off-by: Christoph Egger<Christoph.Egger@xxxxxxx>
> >
>  > diff -r dcb46110d460 -r e8ce7e3e4b8c tools/libxl/xl_cmdimpl.c
>  > --- a/tools/libxl/xl_cmdimpl.c
>  > +++ b/tools/libxl/xl_cmdimpl.c
>  > @@ -5455,7 +5455,7 @@ int main_cpupoolcreate(int argc, char **
>  >      if (!xlu_cfg_get_string (config, "name", &buf))
>  >          name = strdup(buf);
>  >      else
>  > -        name = basename(filename);
>  > +        name = strrchr(filename, '/') + 1;
>  >      if (!libxl_name_to_cpupoolid(&ctx, name, &poolid)) {
>  >          fprintf(stderr, "Pool name \"%s\" already exists\n", name);
>  >          return -ERROR_FAIL;
>
> This is not correct.
> strrchr returns NULL here if filename contains no '/'. This leads to name
> being 1.

Thanks for pointing this out. I haven't considered that case.

Christoph


-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>