Re: [Xen-devel][PATCH]improve suspend_evtchn lock processing

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Chun Yan Liu writes ("Re: [Xen-devel][PATCH]improve suspend_evtchn lock 
processing"):
> Yes. Using fctrl or flock instead can avoid the problem, better than an 
> O_EXCL lock file.
> I made a patch to use flock instead, please have a review:

Thanks for this patch and sorry for the delay replying.  I have just a
few comments:

> diff -r 3c4c3d48a835 tools/libxc/xc_suspend.c
> --- a/tools/libxc/xc_suspend.c    Thu Aug 26 11:16:56 2010 +0100
> +++ b/tools/libxc/xc_suspend.c    Fri Nov 26 19:41:23 2010 +0800
> @@ -16,19 +16,19 @@
...
> +#include 

That looks like a mistake.

> @@ -127,8 +115,7 @@
>      return suspend_evtchn;
>  
>  cleanup:
> -    if (suspend_evtchn != -1)
> -        xc_suspend_evtchn_release(xch, xce, domid, suspend_evtchn);
> +    xc_suspend_evtchn_release(xch, xce, domid, suspend_evtchn);
>  
>      return -1;
>  }

What is this change for ?

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel