WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [PATCH] pvops: fix "xm save -c" issue

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] [PATCH] pvops: fix "xm save -c" issue
From: Kenji Wakamiya <wkenji@xxxxxxxxxxxxxx>
Date: Tue, 14 Dec 2010 14:31:36 +0900
Delivery-date: Mon, 13 Dec 2010 21:33:05 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird 2.0.0.24 (Windows/20100228)
Hi,

I'm investigating the issue of "xm save -c" in case of PV guests.
Then, I tried to prevent calling dpm_resume_end() when suspend was
canceled. It seems to work fine about blk and net.
How about this?

Thanks,

Signed-off-by: Kenji Wakamiya <wkenji@xxxxxxxxxxxxxx>
Signed-off-by: Kazuhiro Suzuki <kaz@xxxxxxxxxxxxxx>
-- 
Kenji Wakamiya

diff --git a/drivers/xen/manage.c b/drivers/xen/manage.c
index 0b50906..3dcc270 100644
--- a/drivers/xen/manage.c
+++ b/drivers/xen/manage.c
@@ -148,11 +148,10 @@ out_resume:
        if (!cancelled) {
                xen_arch_resume();
                xs_resume();
+               dpm_resume_end(PMSG_RESUME);
        } else
                xs_suspend_cancel();
 
-       dpm_resume_end(PMSG_RESUME);
-
        /* Make sure timer events get retriggered on all CPUs */
        clock_was_set();
 
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>