WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] libxl: Use xenbus to communicate with xenstore i

To: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] libxl: Use xenbus to communicate with xenstore if the socket fails
From: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Date: Fri, 10 Dec 2010 17:49:40 +0000
Cc: Mihir Nanavati <mihirn@xxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Vincent Hanquez <Vincent.Hanquez@xxxxxxxxxxxxx>
Delivery-date: Fri, 10 Dec 2010 09:50:33 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1291981951.13966.4842.camel@xxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Newsgroups: chiark.mail.xen.devel
References: <AANLkTiketBP-qtBE6su=Wkob8FEvvcht+KZDEVm6iDKS@xxxxxxxxxxxxxx> <1291886276.13966.4612.camel@xxxxxxxxxxxxxxxxxxxxxx> <4D00AA19.30205@xxxxxxxxxxxxx> <1291890116.13966.4619.camel@xxxxxxxxxxxxxxxxxxxxxx> <4D00B53F.2020903@xxxxxxxxxxxxx> <1291894771.13966.4667.camel@xxxxxxxxxxxxxxxxxxxxxx> <AANLkTinT5sSYqhPqo0he5CvLub0a2QcE-JH5fosxKR8s@xxxxxxxxxxxxxx> <1291975404.13966.4712.camel@xxxxxxxxxxxxxxxxxxxxxx> <AANLkTikERSjFEz9kqmUGwQcX7fQHZ=d6Mdt_-Sd9XTcj@xxxxxxxxxxxxxx> <1291977913.13966.4757.camel@xxxxxxxxxxxxxxxxxxxxxx> <AANLkTi=fkdJjJCK8m837wRUEYrNjK=UtiZbitMLubhXb@xxxxxxxxxxxxxx> <1291980266.13966.4808.camel@xxxxxxxxxxxxxxxxxxxxxx> <AANLkTimUCFzD2dkqa_XJV_SK4U3WRZ05Pik29NuOBAmz@xxxxxxxxxxxxxx> <1291981951.13966.4842.camel@xxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Ian Campbell writes ("Re: [Xen-devel] [PATCH] libxl: Use xenbus to communicate 
with xenstore if the socket fails"):
> On Fri, 2010-12-10 at 11:39 +0000, Mihir Nanavati wrote:
> > Sorry, that was rather confusing ;) Hope this reads better.

Thanks for the patch.

> Much, thanks!
> 
> I think "int mode" should be "unsigned long flags" but don't feel that
> strongly so:
>       Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

It should be unsigned of some kind, surely, and you're right about the
name  I'll fix that up.

> (If you are submitting as an attachment I think IanJ/Stefano will prefer
> if you duplicate the changelog in the attachement as well as in the body
> so they don't need to reconstruct the commit)

In general, I would definitely prefer it if revised patches contained
a fresh copy of the original changelog comment, with a notes about
what changed, if applicable.  That saves going back in the thread
trying to find which message has the changelog comment and trying to
decide whether the old comment still applies.  I'm not that bothered
about the exact format.

In this case I think the original comment from the top of the thread
will do.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>