WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 1/4] amd iommu: Large io page support - Interface

To: Wei Wang2 <wei.wang2@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 1/4] amd iommu: Large io page support - Interface
From: Keir Fraser <keir@xxxxxxx>
Date: Fri, 03 Dec 2010 08:21:03 -0800
Cc:
Delivery-date: Fri, 03 Dec 2010 08:23:52 -0800
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:user-agent:date :subject:from:to:message-id:thread-topic:thread-index:in-reply-to :mime-version:content-type:content-transfer-encoding; bh=DwD15Q8SW3q9SpJQpe3f6ED4kTn9iXTmCjeG0jHQ0Ss=; b=rNHyvS+z258T7xtS/6xNwBnkBHSmCOejiBR3ss6nlfJoK3DJQrkoDxqxo9aW0N1SnQ 9P8wmDd04DsaUGGFr26CxlS1hC3KHLcrgs4Z5Y9a9fS+FDQcN+XNThwdnQo7JZbBPM47 SuBikOl20AS74v+q1eDSLqo6lRc2MfqSYmZoc=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:user-agent:date:subject:from:to:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=bwO1NA4amiciFt5WUSKQaqk29YAIGB9XPAyOS2z2/ErzJCzhVNcyaeQd8mzoLUCP5b ecM3NcW5bM48YT2gHSsovTC+cGUQweYw7fKCcfaAEx0Y1N5aPqMQ0O9c9zz67zuMc3bP bcNTlSD639gIYHwOxIh37vVpvWpJT31Ik9TzI=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C91E581C.14C7B%keir@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcuTBZaKiGvGiy+z5E+xTMh6k8PkuAAAH3Gi
Thread-topic: [Xen-devel] [PATCH 1/4] amd iommu: Large io page support - Interface
User-agent: Microsoft-Entourage/12.23.0.091001
Also the patch uses but does not define amd_iommu_map_pages(). Looks like
you took one big patch and arbitrarily cut it up into a patch series. That
is pointless if the series does not step-wise build and work.

 -- Keir

On 03/12/2010 08:17, "Keir Fraser" <keir@xxxxxxx> wrote:

> Why add new map/unmap calls. Better just to extend the existing calls to be
> able to act on a range, eh? That way you won't end up stubbing out and
> breaking Intel support in patch 3, either...
> 
>  -- Keir
> 
> On 03/12/2010 08:03, "Wei Wang2" <wei.wang2@xxxxxxx> wrote:
> 
>> This patch extends generic iommu interfaces to support different page size.
>> 
>> Thanks,
>> Wei
>> Signed-off-by: Wei Wang <wei.wang2@xxxxxxx>
>> --
>> Legal Information:
>> Advanced Micro Devices GmbH
>> Sitz: Dornach, Gemeinde Aschheim,
>> Landkreis München Registergericht München,
>> HRB Nr. 43632
>> Geschäftsführer:
>> Alberto Bozzo, Andrew Bowd
>> _______________________________________________
>> Xen-devel mailing list
>> Xen-devel@xxxxxxxxxxxxxxxxxxx
>> http://lists.xensource.com/xen-devel
> 
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel