Re: [Xen-devel] hypervisor crash with latest xen-unstable

To:	Keir Fraser <keir@xxxxxxx>
Subject:	Re: [Xen-devel] hypervisor crash with latest xen-unstable
From:	Juergen Gross <juergen.gross@xxxxxxxxxxxxxx>
Date:	Fri, 26 Nov 2010 06:32:57 +0100
Cc:	"xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date:	Thu, 25 Nov 2010 21:33:54 -0800
Dkim-signature:	v=1; a=rsa-sha256; c=simple/simple; d=ts.fujitsu.com; i=juergen.gross@xxxxxxxxxxxxxx; q=dns/txt; s=s1536b; t=1290749580; x=1322285580; h=message-id:date:from:mime-version:to:cc:subject: references:in-reply-to:content-transfer-encoding; z=Message-ID:=20<4CEF4689.10500@xxxxxxxxxxxxxx>\|Date:=20Fr i,=2026=20Nov=202010=2006:32:57=20+0100\|From:=20Juergen =20Gross=20<juergen.gross@xxxxxxxxxxxxxx>\|MIME-Version: =201.0\|To:=20Keir=20Fraser=20<keir@xxxxxxx>\|CC:=20"xen-de vel@xxxxxxxxxxxxxxxxxxx"=20<xen-devel@xxxxxxxxxxxxxxxxxxx >\|Subject:=20Re:=20[Xen-devel]=20hypervisor=20crash=20wit h=20latest=20xen-unstable\|References:=20<C91449E7.B1E6%ke ir@xxxxxxx>\|In-Reply-To:=20<C91449E7.B1E6%keir@xxxxxxx> \|Content-Transfer-Encoding:=207bit; bh=Y6gTxFRmBTY8nLeZaFE+zRUJpaj0pmj4+BO7J1YDfg0=; b=M7c3ON7/Hcbt5LyzGeHiKjI8y+IF7DXbYdMwaYOyGXbop5dZ6OkM3i1R puYu3sZFAUbFvMQ6+IF7HcUYnnxSJrJSvz4EeH20cpMIdyW3pAn+pestN mMC8OC/xr4rIM6gGI1q7ZWXLKH448xzGwq/avn0/sg+y9X6907sbtvpQo BdDDn5JpJ/2C/CJHSh8jOVXlcXmsPLNnBwtEPqqmIXVNOZqQneTQBwyTa 6q8wEChznPFJNKvzFRyMVIUz8Lp9h;
Domainkey-signature:	s=s1536a; d=ts.fujitsu.com; c=nofws; q=dns; h=X-SBRSScore:X-IronPort-AV:Received:X-IronPort-AV: Received:Received:Message-ID:Date:From:Organization: User-Agent:MIME-Version:To:CC:Subject:References: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=HYUqnyYVWShTPzPCb46654l2Vuhe7urypvzF9FH/IuKX7AkNQ0sLf9VU rChSvamSz0IfIYpF2vYhdC7jgp4s8i/JmIyRXofWCYL76Zpowef3dx0Ve w7kdWJaSfm9uCZkxFx7XTqXkkpk8tRIwQ6h4a70XnAmp9f3UzjXOMc0fs Ng2cM/kwFyztbD8rGPYuHFIkQ93PuFqwWWFTt9wjMiLwSQRtqSsLIJBLs /v0b+o7z7eyU/Of8cMbgLKzoCdQtW;
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<C91449E7.B1E6%keir@xxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization:	Fujitsu Technology Solutions
References:	<C91449E7.B1E6%keir@xxxxxxx>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent:	Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.15) Gecko/20101030 Iceowl/1.0b1 Icedove/3.0.10

On 11/25/10 18:14, Keir Fraser wrote:

On 25/11/2010 10:27, "Juergen Gross"<juergen.gross@xxxxxxxxxxxxxx>  wrote:

(XEN) Xen call trace:
(XEN)    [<ffff82c4801212f9>] do_softirq+0x51/0x7a
(XEN)

I suspect the waitqueue stuff broke the continue_hypercall_on_cpu() stuff.


Then please bisect to confirm that.


Removing the ASSERT(!in_atomic()) in do_softirq() and schedule() makes it
work again. And these assertions were added with cs22395.

The question now is, whether these assertions are wrong or if it is just
working by chance without them.
It seems to be necessary to be able to call schedule() in this case, as adding

if (in_atomic()) return;

to do_softirq() made the hypercall hang.


Juergen

--
Juergen Gross                 Principal Developer Operating Systems
TSP ES&S SWE OS6                       Telephone: +49 (0) 89 3222 2967
Fujitsu Technology Solutions              e-mail: juergen.gross@xxxxxxxxxxxxxx
Domagkstr. 28                           Internet: ts.fujitsu.com
D-80807 Muenchen                 Company details: ts.fujitsu.com/imprint.html

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

WARNING - OLD ARCHIVES

xen-devel

Re: [Xen-devel] hypervisor crash with latest xen-unstable