WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] xenalyze: Use types which have consistent sizes

To: George Dunlap <george.dunlap@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] xenalyze: Use types which have consistent sizes across 32- and 64-bit compiles
From: Olaf Hering <olaf@xxxxxxxxx>
Date: Thu, 25 Nov 2010 12:17:58 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 25 Nov 2010 03:19:01 -0800
Dkim-signature: v=1; a=rsa-sha1; c=relaxed/relaxed; t=1290683882; l=266; s=domk; d=aepfle.de; h=In-Reply-To:Content-Type:MIME-Version:References:Subject:Cc:To:From: Date:X-RZG-CLASS-ID:X-RZG-AUTH; bh=Iwb84bsdrWD/USL+rnIPAtrZ7J4=; b=tZGPJdbTrEF4pDxvko0s1PLg7aB3sXOz/Ctr2O3nC6w1KMV93zJtB8NdiE0fop7g3DC PjUFl3nRulntIN+IzGX7o6FJvcvotJvcsas3wwsjYgXZQEzt1KYbY/i75vflAzvTOupt2 QtFI9kIYn5qu50K+gFT/prszyO9N3faz1gY=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <9b3c5bb22b50106a254d.1290426236@gdunlap-desktop>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <9b3c5bb22b50106a254d.1290426236@gdunlap-desktop>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.20 (2009-06-14)
On Mon, Nov 22, George Dunlap wrote:

> Always use [unsigned] long long for 64-bit, [unsigned] int for 32-bit.

George,

there are two unsigned long left in hvm_mmio_assist_process().
I think the sizeof(unsigned long) should be sizeof(unsigned int).

Olaf

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel