|
|
|
|
|
|
|
|
|
|
xen-devel
[Xen-devel] Re: [PATCH -next] xen: fix header export to userspace
To: |
Randy Dunlap <randy.dunlap@xxxxxxxxxx> |
Subject: |
[Xen-devel] Re: [PATCH -next] xen: fix header export to userspace |
From: |
Tony Finch <dot@xxxxxxxx> |
Date: |
Mon, 15 Nov 2010 10:23:48 +0000 |
Cc: |
Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>, Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, LKML <linux-kernel@xxxxxxxxxxxxxxx>, virtualization@xxxxxxxxxxxxxx, linux-next@xxxxxxxxxxxxxxx, akpm <akpm@xxxxxxxxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx |
Delivery-date: |
Tue, 16 Nov 2010 01:46:08 -0800 |
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxxx |
In-reply-to: |
<20101113084439.d21bd0f0.randy.dunlap@xxxxxxxxxx> |
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
List-post: |
<mailto:xen-devel@lists.xensource.com> |
List-subscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
List-unsubscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
References: |
<20101112130547.c2a3c2c1.sfr@xxxxxxxxxxxxxxxx> <20101113084439.d21bd0f0.randy.dunlap@xxxxxxxxxx> |
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
User-agent: |
Alpine 2.00 (LSU 1167 2008-08-23) |
On Sat, 13 Nov 2010, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
>
> scripts/headers_install.pl prevents "__user" from being exported
> to userspace headers, so just use compiler.h to make sure that
> __user is defined and avoid the error.
>
> unifdef: linux-next-20101112/xx64/usr/include/xen/privcmd.h.tmp: 79:
> Premature EOF (#if line 33 depth 1)
I suggest the following slightly more informative message
> scripts/headers_install.pl strips "__user" when exporting headers to
> userspace and can introduce a syntax error (detected by unifdef) if
> "__user" appears in an unexpected place. Simplify by using compiler.h to
> make sure that __user is defined and avoid the error.
>
> unifdef: linux-next-20101112/xx64/usr/include/xen/privcmd.h.tmp: 79:
> Premature EOF (#if line 33 depth 1)
In any case,
Acked-By: Tony Finch <dot@xxxxxxxx>
Tony.
--
f.anthony.n.finch <dot@xxxxxxxx> http://dotat.at/
HUMBER THAMES DOVER WIGHT PORTLAND: NORTH BACKING WEST OR NORTHWEST, 5 TO 7,
DECREASING 4 OR 5, OCCASIONALLY 6 LATER IN HUMBER AND THAMES. MODERATE OR
ROUGH. RAIN THEN FAIR. GOOD.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
|
|