Re: [Xen-devel] [PATCH V5 6/6] piix4acpi: change in ACPI to match the change in the BIOS.

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

anthony.perard@xxxxxxxxxx writes ("[Xen-devel] [PATCH V5 6/6] piix4acpi: change 
in ACPI to match the change in the BIOS."):
> -    reg_count = addr - (ACPI_GPE0_BLK_ADDRESS + ACPI_GPE0_BLK_LEN / 2);
> +    if (s->use_old_ioport)
> +        reg_count = addr - (ACPI_GPE0_BLK_ADDRESS_OLD + 
> ACPI_GPE0_BLK_LEN_OLD / 2);
> +    else
> +        reg_count = addr - (ACPI_GPE0_BLK_ADDRESS + ACPI_GPE0_BLK_LEN / 2);

There are lots of this kind of pattern in this patch.  I think it
would be better to make variables in GPEState called gpe0_blk_address
and gpe0_blk_len and use them consistently.

As well as being better style, that would make the patch less
disruptive and so make it easier to cross-port changes in future.


If I'm not mistaken, your 1/6, 4/6 and 6/6 all need to go in together ?
In which case 1/6 and 4/6 should be one patch, not two.

Re the qemu and xen patches, I can combine them.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel