Re: [Xen-devel] Re: [PATCH]: gdbsx: Check return of write()

To:	Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Subject:	Re: [Xen-devel] Re: [PATCH]: gdbsx: Check return of write()
From:	Bruce Edge <bruce.edge@xxxxxxxxx>
Date:	Wed, 3 Nov 2010 07:10:32 -0700
Cc:	Olaf Hering <olaf@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Gianni Tedesco <gianni.tedesco@xxxxxxxxxx>
Delivery-date:	Wed, 03 Nov 2010 07:11:39 -0700
Dkim-signature:	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:cc:content-type; bh=bflsnWUEaEPOg1pXahY5C3UsWhjmN0CCtOP6/bj0sG0=; b=QWAWNm25oA3x2EM1RVuQU/Y2aoqYFn2MAcVMKqHqc+/5P7cFC0DfjYlaa7ASX6u75F 5tVcCtaXfJ0S2gs6g1kg83Uw239YTdcb76JZpon7R5H7WacLD+AOdt/tyV8f6f+l7RQj JDO6Tr5hzDyNUKBXg6Zh7DqPeBO+53j761Xf4=
Domainkey-signature:	a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=SMMh1rtBIYSRBwf4ZYwq5P59nGbJ7CWd145IavjNuUuoC8d3+srmKT8ius1+/kYgRB 8tYFLZPE0oH6MuIJTDhgqPQ+t2qrGbl08Vg1wZRoIg4kRo+wobsdyqetv3xkwRpcVa45 WNw/6orvOjvULW3lj/j9MW5JjQWWIAcpKnbR8=
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<19665.20124.997347.267958@xxxxxxxxxxxxxxxxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References:	<20101102103414.GA13749@xxxxxxxxx> <1288714297.23619.59.camel@xxxxxxxxxxxxxxxxxxxxxx> <19665.20124.997347.267958@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

On Wed, Nov 3, 2010 at 4:59 AM, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx> wrote:

Gianni Tedesco writes ("[PATCH]: gdbsx: Check return of write()"):

> - write(remote_fd, "-", 1);
> + if ( write(remote_fd, "-", 1) != 1 )
> + perror("write");

Thanks. I've applied this. I fixed the formatting to be constent
with the other parts of the same file, and also arranged for errors to
actually cause the function to return -1 as the head comment suggests
it should.

What branch is this applied to?
I'm not seeing it in http://xenbits.xensource.com/xen-unstable.hg

-Bruce

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

WARNING - OLD ARCHIVES

xen-devel

Re: [Xen-devel] Re: [PATCH]: gdbsx: Check return of write()