 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [Patch 2/4] Refining Xsave/Xrestore support
| To: | Jan Beulich <JBeulich@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [Patch 2/4] Refining Xsave/Xrestore support |
| From: | Haitao Shan <maillists.shan@xxxxxxxxx> |
| Date: | Thu, 28 Oct 2010 15:52:10 +0800 |
| Cc: | xen-devel@xxxxxxxxxxxxxxxxxxx, Weidong Han <weidong.han@xxxxxxxxx>, Keir Fraser <keir.fraser@xxxxxxxxxxxxx> |
| Delivery-date: | Thu, 28 Oct 2010 00:53:44 -0700 |
| Dkim-signature: | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:cc:content-type; bh=XXxQc47kjjBHIZmTYCFNvkJChjYeSCgj0K9T9wIc5Cw=; b=UqAxEAdPfHMlQxP+eSF5DzE7/+hwoCbkg61HAaN7LYv7WM32nPZVokpNikoTLVrbfn e/UdJt9BEeqkl6PYB//ZB0ZWwOaVcensAQ8Y6rS4e9oAqeTfX2lqDCmleC5rnwnRvUQJ WYfcpLV62VpKV2Z7angCIQBJSwn9I0Ep2JvS4= |
| Domainkey-signature: | a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=Psk6H9ndWFQg+PYcZjvNQGOgZD8dvZCuRMn+ivb91tp3Rfx9xNRvhw+htp4BthodUZ uvZe9y6K6PucBuG2Av/r7R/2wOWevR6Wz5yySe3CuTZ4RsReecTYkZalt9H/w68qIA2L +OQPHqhNG3aj9g42CYH2gGCDQWKnVomxVPiiU= |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <4CC93F2B020000780001FA2E@xxxxxxxxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| References: | <AANLkTimWUuyHvZ06=2cRBhvw2fcfMzA5QAuJZJso7=gY@xxxxxxxxxxxxxx> <4CC81AD8020000780001F6BE@xxxxxxxxxxxxxxxxxx> <AANLkTim5DO3HQ_QCv-MK4auz7GDY3Mx+8g7MQJgsiVPS@xxxxxxxxxxxxxx> <4CC93F2B020000780001FA2E@xxxxxxxxxxxxxxxxxx> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
Then I would prefer to write XCR0 unconditionally. Otherwise, I can only refer to the approach for handling CR4 switches: reading CR4 first and checking whether there is a need to write actually. But I don't think <a read to XCR0 plus a data comparison> can save any compared with one unconditional write to XCR0. Are you OK with this? Thanks for pointing out the memory leak when hvm_vcpu_initialize fails. I will update accordingly. Shan Haitao 2010/10/28 Jan Beulich <JBeulich@xxxxxxxxxx>: >>>> On 28.10.10 at 06:58, Haitao Shan <maillists.shan@xxxxxxxxx> wrote: >> This is the updated patch#2. Thanks. > > Sorry, but this is worse than not checking at all: You didn't consider > the idle vCPU case here, and hence you may end up having more > features enabled in xcr0 for a guest than it should have. > > Also I only now noticed that you're leaking the xsave_area allocation > in vcpu_initialize() if hvm_vcpu_initialise() fails. > > Jan > > _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Xen-devel] Why is cpu-to-node mapping different between Xen 4.0.2-rc1-pre and Xen 4.1-unstable?, Jan Beulich |
|---|---|
| Next by Date: | Re: [Xen-devel] [Patch 2/4] Refining Xsave/Xrestore support, Haitao Shan |
| Previous by Thread: | Re: [Xen-devel] [Patch 2/4] Refining Xsave/Xrestore support, Jan Beulich |
| Next by Thread: | Re: [Xen-devel] [Patch 2/4] Refining Xsave/Xrestore support, Jan Beulich |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
