WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] xen: do not unmask disabled IRQ on eoi.

To: Jan Beulich <JBeulich@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] xen: do not unmask disabled IRQ on eoi.
From: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>
Date: Fri, 22 Oct 2010 09:34:26 +0100
Cc: "jeremy@xxxxxxxx" <jeremy@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>
Delivery-date: Fri, 22 Oct 2010 01:36:19 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4CC16797020000780001E8F7@xxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Citrix Systems, Inc.
References: <1287139966-19391-2-git-send-email-ian.campbell@xxxxxxxxxx> <alpine.DEB.2.00.1010151614420.2423@kaball-desktop> <1287160335.2003.7973.camel@xxxxxxxxxxxxxxxxxxxxxx> <1287160787.2003.7979.camel@xxxxxxxxxxxxxxxxxxxxxx> <alpine.DEB.2.00.1010151757240.2423@kaball-desktop> <4CBC1CF1020000780001DA3F@xxxxxxxxxxxxxxxxxx> <alpine.DEB.2.00.1010181530200.2423@kaball-desktop> <4CBC80E6020000780001DC78@xxxxxxxxxxxxxxxxxx> <alpine.DEB.2.00.1010181754180.2423@kaball-desktop> <4CBD5883020000780001DEC4@xxxxxxxxxxxxxxxxxx> <alpine.DEB.2.00.1010211411100.10348@kaball-desktop> <4CC15C5B020000780001E8B2@xxxxxxxxxxxxxxxxxx> <1287734836.29224.648.camel@xxxxxxxxxxxxxxxxxxxxx> <4CC16797020000780001E8F7@xxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Fri, 2010-10-22 at 09:29 +0100, Jan Beulich wrote:
> >>> On 22.10.10 at 10:07, Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx> wrote:
> > On Fri, 2010-10-22 at 08:41 +0100, Jan Beulich wrote: 
> >> >>> On 21.10.10 at 15:36, Stefano Stabellini 
> >> >>> <stefano.stabellini@xxxxxxxxxxxxx> wrote:
> >> > --- a/drivers/xen/events.c
> >> > +++ b/drivers/xen/events.c
> >> > @@ -436,21 +436,50 @@ static bool identity_mapped_irq(unsigned irq)
> >> >          return irq < get_nr_hw_irqs();
> >> >  }
> >> >  
> >> > -static void pirq_eoi(unsigned int irq)
> >> > +static void eoi_pirq(unsigned int irq)
> >> >  {
> >> >          struct irq_info *info = info_for_irq(irq);
> >> >          struct physdev_eoi eoi = { .irq = info->u.pirq.gsi };
> >> > -        bool need_eoi;
> >> > +        int evtchn = evtchn_from_irq(irq);
> >> > +        int rc = 0, need_mask = 0;
> >> > +        struct shared_info *s = HYPERVISOR_shared_info;
> >> >  
> >> > -        need_eoi = pirq_needs_eoi(irq);
> >> > +        if (!VALID_EVTCHN(evtchn))
> >> > +                return;
> >> >  
> >> > -        if (!need_eoi || !pirq_eoi_does_unmask)
> >> > -                unmask_evtchn(info->evtchn);
> >> > +        move_masked_irq(irq);
> >> 
> >> It's not clear whether calling this function is valid when the IRQ isn't
> >> really masked.
> >> 
> >> In any case I'd suggest adding an IRQ_DISABLED check matching
> >> move_native_irq()'s.
> > 
> > Why not just call move_native_irq instead of move_masked_irq as
> > appropriate?
> 
> That was what I implied with the first part of my response.

Too subtle for me ;-)

> But I think the second part applies if a (the conditional) call to
> move_masked_irq() would stay.

Agreed, although I suspect we should know if the evtchn is masked or not
at this point depending on the already known properties of the
particular pirq (need_eoi, pirq_eoi_does_unmask etc).

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel