WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [Qemu-devel] [PATCH V5 09/14] xen: Introduce the Xen map

To: anthony.perard@xxxxxxxxxx
Subject: [Xen-devel] Re: [Qemu-devel] [PATCH V5 09/14] xen: Introduce the Xen mapcache
From: Blue Swirl <blauwirbel@xxxxxxxxx>
Date: Sun, 17 Oct 2010 16:16:59 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, qemu-devel@xxxxxxxxxx, Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Delivery-date: Sun, 17 Oct 2010 09:18:10 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:cc:content-type; bh=OMJg0Km87jazJxPT67jIP7XwvDq185Xmjf69eJ5jtt0=; b=i1a/WTqnCr2HimgV3WoXOLNIItW7fIUwHrzy0tH+9IBZfjaFZbZ9Wd2hvDta4m8w+h mxJ4H13p5usqMJRJ7mcIEPzfDWO2wZCwq1j6YHJ4Xex/n0/l2k3cy4onI5IYRqXiicu3 zqGMMo8cz46OEExWmZGLBxUjY7q09bdTu4vio=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; b=tVoMC/GSH0S0U9NTs0S8J6Ns0KDz24nxym/Tr02j9cQnThdRp/8otbcMumfdM5H9Yj epgDZKsoBpGkdk40m9x/hjci8T9ozzYEc60CrOADaac5hzEk39TeGQh/iHAwXbkIQmgA LVyMpHhb5lbzyo+b/A+LH7jdzhyvE78k109cw=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1286813230-17539-10-git-send-email-anthony.perard@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1286813230-17539-1-git-send-email-anthony.perard@xxxxxxxxxx> <1286813230-17539-10-git-send-email-anthony.perard@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Mon, Oct 11, 2010 at 4:07 PM,  <anthony.perard@xxxxxxxxxx> wrote:
> From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
>
> The mapcache maps chucks of guest memory on demand, unmaps them when
> they are not needed anymore.
>
> Each call to qemu_get_ram_ptr makes a call to qemu_map_cache with the
> lock option, so mapcache will not unmap these ram_ptr.

I'm getting these errors:
/src/qemu/xen-mapcache.c: In function 'qemu_map_cache_init':
/src/qemu/xen-mapcache.c:71: error: large integer implicitly truncated
to unsigned type
/src/qemu/xen-mapcache.c: In function 'qemu_map_cache':
/src/qemu/xen-mapcache.c:173: error: large integer implicitly
truncated to unsigned type
/src/qemu/xen-mapcache.c: In function 'qemu_invalidate_entry':
/src/qemu/xen-mapcache.c:258: error: large integer implicitly
truncated to unsigned type
/src/qemu/xen-mapcache.c: In function 'qemu_invalidate_map_cache':
/src/qemu/xen-mapcache.c:331: error: large integer implicitly
truncated to unsigned type

In all cases, the offending line is:
 mapcache->last_address_index = ~0UL;

Since the type of last_address_index is target_phys_addr_t, these should become:
 mapcache->last_address_index = (target_phys_addr_t)~0UL;

Changing ~0UL to ~0ULL or -1 may also work.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>