WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

AW: [Xen-devel] Problem compiling Kernel 2.6.18 - netfront.c

To: Jan Beulich <JBeulich@xxxxxxxxxx>, Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Subject: AW: [Xen-devel] Problem compiling Kernel 2.6.18 - netfront.c
From: Carsten Schiers <carsten@xxxxxxxxxx>
Date: Tue, 12 Oct 2010 12:34:36 +0200
Cc: Ky Srinivasan <KSrinivasan@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 12 Oct 2010 03:35:33 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4CB44C8B020000780001C6EA@xxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Sorry, my machine is pretty slow and I wanted to do a fresh compile...

Yes, solves the issue. Just saw that the patch is already in the repo.

Thanks,
Carsten.


----- Originalnachricht -----
Von: Jan Beulich <JBeulich@xxxxxxxxxx>
Gesendet: Die, 12.10.2010 11:54
An: Ian Campbell <Ian.Campbell@xxxxxxxxxx> ; Carsten Schiers 
<carsten@xxxxxxxxxx>
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx ; Ky Srinivasan <KSrinivasan@xxxxxxxxxx>
Betreff: Re: [Xen-devel] Problem compiling Kernel 2.6.18 - netfront.c

>>> On 12.10.10 at 11:20, Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:
> Looks like 2.6.18 sysfs differs from whichever kernel the patch was
> originally written against.

Yes, I'm sorry for that, I didn't notice that the corresponding code in
netback changed twice (in .21 and .30).

> Untested patch based on the netback get_drvinfo method from 2.6.18
> below, does it work for you?

Looks exactly like what's needed.

Acked-by: Jan Beulich <jbeulich@xxxxxxxxxx>

> diff -r 578f036ec7dd drivers/xen/netfront/netfront.c
> --- a/drivers/xen/netfront/netfront.c    Mon Oct 11 10:25:55 2010 +0100
> +++ b/drivers/xen/netfront/netfront.c    Tue Oct 12 10:19:15 2010 +0100
> @@ -1776,7 +1776,7 @@ static void netfront_get_drvinfo(struct 
>                   struct ethtool_drvinfo *info)
>  {
>      strcpy(info->driver, "netfront");
> -    strcpy(info->bus_info, dev_name(dev->dev.parent));
> +    strcpy(info->bus_info, dev->class_dev.dev->bus_id);
>  }
>  
>  static int network_connect(struct net_device *dev)
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx 
> http://lists.xensource.com/xen-devel 




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>