WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] libxl: copy & paste bug

To: Christoph Egger <Christoph.Egger@xxxxxxx>
Subject: Re: [Xen-devel] libxl: copy & paste bug
From: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Date: Tue, 5 Oct 2010 11:08:18 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Tue, 05 Oct 2010 03:08:55 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <201010051205.39864.Christoph.Egger@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Citrix Systems, Inc.
References: <201010051205.39864.Christoph.Egger@xxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Tue, 2010-10-05 at 11:05 +0100, Christoph Egger wrote:
> Hi!
> 
> In tools/libxl/libxl_bootloader.c, at the end of the
> function libxl_run_bootloader() are the following lines:
> 
> if (fifo_fd > -1)
>     close(fifo_fd);
> if (bootloader_fd > -1)
>     close(bootloader_fd);
> if (xenconsoled_fd > -1)
>     close(xenconsoled_fd);
> if (xenconsoled_slave > -1)
>     close(xenconsoled_fd);
> 
> The last line is wrong. It should be:
> 
>     close(xenconsoled_slave);

Indeed. Please can you post a patch.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>