WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH] [Linux] ia64, xencomm: fix 1028:6f7bda25a4de

KUWAMURA Shin'ya writes ("[Xen-devel]  Re: [PATCH] [Linux] ia64, xencomm: fix 
1028:6f7bda25a4de"):
> On Mon, 13 Sep 2010 09:38:50 +0100
> JBeulich@xxxxxxxxxx("Jan Beulich")  said:
> > Even more, a few lines down in the same source file __XEN__
> > already gets #define-d, so the first choice imo would be to simply
> > move that definition up. Or does this cause any *more* problems
> > than the warning above (which I think needs to be dealt with
> > regardless)?

Jan's suggestion seems sensible.

> Thank you for your advice.
> 
> I fixed this warning by adding an #include line. I attached the patch.
...
> +#include <xen/interface/xen-compat.h>
> +#define __XEN_TOOLS__

Why do you choose to #define __XEN_TOOLS__ rather than __XEN__ (which
latter is already defined in this file, as Jan notes) ?

Does moving the definition of __XEN__ further up cause other problems ?

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel