| |
|
 |
|
 |
|
|
|
| |
|
|
xen-devel
[Xen-devel] Re: [PATCH] re-enable HVM PCI passthrough functionality
At 02:58 +0100 on 31 Aug (1283223494), Kay, Allen M wrote:
> Attached patch reverts back to INVALID_MFN. PCI passthrough functionality
> works with this patch.
>
Apologies for missing this - I did ask for this enormous patch to
contain only what it said on the tin (and I did read it to check!) but
this one got through.
> Signed-off-by: Allen Kay allen.m.kay@xxxxxxxxx
>
This is fine, but please add a comment explaining the rather subtle use
of INVALID_MFN here so the next tidy-minded person doesn't "fix" it
again. :)
In fact would it be better to check the returned type == p2m_mmio_direct
instead? That seems like it would fit better with the intention. Or
do other callers use this to clean non-mmio entries too?
Cheers,
Tim.
--
Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Principal Software Engineer, XenServer Engineering
Citrix Systems UK Ltd. (Company #02937203, SL9 0BG)
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
| |
|
Home