WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] [PATCH] xl: obey uuid config option

To: Owen Smith <owen.smith@xxxxxxxxxx>
Subject: RE: [Xen-devel] [PATCH] xl: obey uuid config option
From: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Date: Fri, 27 Aug 2010 12:40:35 +0100
Cc: Xen Devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>, "Gianni Tedesco \(3P\)" <gianni.tedesco@xxxxxxxxxx>, Stefano Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>
Delivery-date: Fri, 27 Aug 2010 04:43:35 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <DECC4DEE86A8074C9ABE8DFD330CB6E38D059AAE18@xxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1282761718.3731.100.camel@xxxxxxxxxxxxxxxxxxxxxx> <DECC4DEE86A8074C9ABE8DFD330CB6E38D059AAE18@xxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Alpine 2.00 (DEB 1167 2008-08-23)
On Thu, 26 Aug 2010, Owen Smith wrote:
> What should the behaviour be if the uuid config option is a valid string but 
> an invalid format?
> 

good point.
We need to check the return value of libxl_uuid_from_string and act
accordingly.

> -----Original Message-----
> From: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx 
> [mailto:xen-devel-bounces@xxxxxxxxxxxxxxxxxxx] On Behalf Of Gianni Tedesco
> Sent: 25 August 2010 19:42
> To: Xen Devel
> Cc: Ian Jackson; Stefano Stabellini
> Subject: [Xen-devel] [PATCH] xl: obey uuid config option
> 
> Signed-off-by: Gianni Tedesco <gianni.tedesco@xxxxxxxxxx>
> 
> diff -r fd38d1c9f5ac tools/libxl/xl_cmdimpl.c
> --- a/tools/libxl/xl_cmdimpl.c        Wed Aug 25 19:39:05 2010 +0100
> +++ b/tools/libxl/xl_cmdimpl.c        Wed Aug 25 19:44:33 2010 +0100
> @@ -607,7 +607,11 @@ static void parse_config_data(const char
>          c_info->name = strdup(buf);
>      else
>          c_info->name = "test";
> -    libxl_uuid_generate(&c_info->uuid);
> +
> +    if (!xlu_cfg_get_string (config, "uuid", &buf))
> +        libxl_uuid_from_string(&c_info->uuid, buf);
> +    else
> +        libxl_uuid_generate(&c_info->uuid);
>  
>      if (!xlu_cfg_get_long(config, "oos", &l))
>          c_info->oos = l;
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>