| |
|
 |
|
 |
|
|
|
| |
|
|
xen-devel
[Xen-devel] Re: [Bugme-new] [Bug 16529] New: xennet driver crashes when
|
To: |
Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx> |
|
Subject: |
[Xen-devel] Re: [Bugme-new] [Bug 16529] New: xennet driver crashes when using with pseudowire aka l2tpv3 |
|
From: |
Eric Dumazet <eric.dumazet@xxxxxxxxx> |
|
Date: |
Thu, 26 Aug 2010 09:22:34 +0200 |
|
Cc: |
Jeremy Fitzhardinge <jeremy@xxxxxxxx>, "Xen-devel@xxxxxxxxxxxxxxxxxxx" <Xen-devel@xxxxxxxxxxxxxxxxxxx>, "netdev@xxxxxxxxxxxxxxx" <netdev@xxxxxxxxxxxxxxx>, "bugzilla-daemon@xxxxxxxxxxxxxxxxxxx" <bugzilla-daemon@xxxxxxxxxxxxxxxxxxx>, James Chapman <jchapman@xxxxxxxxxxx>, Chris Wright <chrisw@xxxxxxxxxxxx>, "bugme-daemon@xxxxxxxxxxxxxxxxxxx" <bugme-daemon@xxxxxxxxxxxxxxxxxxx>, "heil@xxxxxxxxxxxxxxxxxxxxxx" <heil@xxxxxxxxxxxxxxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> |
|
Delivery-date: |
Thu, 26 Aug 2010 10:12:55 -0700 |
|
Dkim-signature: |
v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:subject:from:to:cc :in-reply-to:references:content-type:date:message-id:mime-version :x-mailer:content-transfer-encoding; bh=pIXa007PwDgdk+40K/oYcIoTp5syIKRx75YypMrZO3U=; b=Or4QWNp9z2+b2fUZ45v1nXWJeXKMLNQWqu4rugc+Nw420gNJ6aghhhk9EwxmCBP61e bHJiVQf+6ZfSfmsYKZpXFt0FAUXgmcAZ0Qyv1cT+1fvuyvbaIlwwdjMxpp3XRFAl+KEM Uyu3JAVPlAVdXYrzTdMK+036BQNPY8hfzpJ1o= |
|
Domainkey-signature: |
a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:to:cc:in-reply-to:references:content-type:date :message-id:mime-version:x-mailer:content-transfer-encoding; b=JlY+PQnqwk4BasLlQrTjjIcGf/pc7UqZuFd1qcIJi0hsR9BaLeF9YzzQWJv1G9YQr/ XwYXLUPa15HzXPfi2+ao/ohyfoAgrtU3VrUptdZi3TGW9bg2/uAE28ihKryIyogH1DTo ba5M9ivQ4lgaQj7kv5JcxtchGVlhir0LuU42A= |
|
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxxx |
|
In-reply-to: |
<1282806640.3469.26.camel@xxxxxxxxxxxxxxxxxxxxx> |
|
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
|
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
|
List-post: |
<mailto:xen-devel@lists.xensource.com> |
|
List-subscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
|
List-unsubscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
|
References: |
<bug-16529-10286@xxxxxxxxxxxxxxxxxxxxxxxxx/> <20100825153107.2f547f0e.akpm@xxxxxxxxxxxxxxxxxxxx> <4C759F8C.9050301@xxxxxxxx> <1282806640.3469.26.camel@xxxxxxxxxxxxxxxxxxxxx> |
|
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
Le jeudi 26 août 2010 à 08:10 +0100, Ian Campbell a écrit :
> On Wed, 2010-08-25 at 23:56 +0100, Jeremy Fitzhardinge wrote:
>
> > >> Here is a link for the setup
> > >> http://www.pastebin.org/445975
> > >> and here a link with more details about the crash
> > >> http://pastebin.org/449221
> >
> > Please attach these to the bug or something; pastebin is not working for
> > me at the moment.
>
> It's really slow for me but got there eventually. I've attached the
> files.
>
> It's apparently hitting this BUG_ON in __skb_pull:
>
> static inline unsigned char *__skb_pull(struct sk_buff *skb, unsigned
> int len)
> {
> skb->len -= len;
> BUG_ON(skb->len < skb->data_len);
> return skb->data += len;
> }
>
> Ian.
>
Thanks a lot.
I'll submit a patch to fix l2tp_eth_dev_recv()
Its illegal to call dev_forward_skb() with a too small payload.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
| |
|
Home