WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH] VT-d: Hardware require RH bit to be set in IRTE

To: Sheng Yang <sheng@xxxxxxxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH] VT-d: Hardware require RH bit to be set in IRTE when delivery mode is LPR
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Thu, 26 Aug 2010 10:24:40 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Thu, 26 Aug 2010 02:25:53 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <201008261717.40223.sheng@xxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: ActE/4cn/gP4E1BoTYmkwn0WU+BVaAAAPs6h
Thread-topic: [PATCH] VT-d: Hardware require RH bit to be set in IRTE when delivery mode is LPR
User-agent: Microsoft-Entourage/12.26.0.100708
On 26/08/2010 10:17, "Sheng Yang" <sheng@xxxxxxxxxxxxxxx> wrote:

> +    /* Hardware require RH = 1 for LPR delivery mode */
> +    if ( new_ire.lo.dlm == dest_LowestPrio )
> +        new_ire.lo.rh = 1;
> +    else
> +        new_ire.lo.rh = 0;

The form 'if ( p ) x = 1; else x = 0;' is better written as 'x = (p)'.
Please re-submit in that style.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>