|
|
|
|
|
|
|
|
|
|
xen-devel
Re: [Xen-devel] [PATCH 20 of 26] xl: free all data on exit from the doma
On Tue, 2010-08-17 at 16:11 +0100, Ian Jackson wrote:
> Ian Campbell writes ("Re: [Xen-devel] [PATCH 20 of 26] xl: free all data on
> exit from the domain monitor daemon"):
> > I think it needs an out_closelog label which does the closing since the
> > regular out label is used from places which do not open the logfile.
> > I'll make that change.
>
> You could avoid messing about with different out labels (always
> error-prone) by closing logfile iff it has been reopened:
> if (logfile != 2) close(logfile)
That's actually what I ended up doing. I'll repost tomorrow once I've
had a chance to rebase on top ofthe applied subset.
(I'll pull this one to the front of the series as well since it's really
a generic fix)
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
<Prev in Thread] |
Current Thread |
[Next in Thread>
|
- [Xen-devel] [PATCH 13 of 26] libxl: libxl_device_console.build_state is const, (continued)
[Xen-devel] [PATCH 17 of 26] xl: free the libxl types contained in struct domain_config, Ian Campbell
[Xen-devel] [PATCH 21 of 26] libxl/xl: use libxl_diskinfo_destroy and libxl_device_disk_destroy, Ian Campbell
[Xen-devel] [PATCH 23 of 26] libxl/xl: Use libxl_vcpuinfo_destroy, Ian Campbell
[Xen-devel] [PATCH 19 of 26] xl: destroy device model info after creation, Ian Campbell
[Xen-devel] [PATCH 24 of 26] xl: use libxl_device_pci_destroy, Ian Campbell
[Xen-devel] [PATCH 22 of 26] libxl/xl: Use libxl_device_nic_destroy and libxl_nicinfo_destroy, Ian Campbell
[Xen-devel] [PATCH 25 of 26] libxl: do not GC data returned to the caller by libxl_device_disk_getinfo, Ian Campbell
[Xen-devel] [PATCH 26 of 26] libxl: xs_read accepts NULL for *len parameter, Ian Campbell
Re: [Xen-devel] [PATCH 00 of 26] libxl: autogenerate type definitions and destructor functions, Gianni Tedesco
|
|
|
|
|