 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH] xen svm: fix PAUSE instruction intercept
| To: | "Christoph Egger" <Christoph.Egger@xxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH] xen svm: fix PAUSE instruction intercept |
| From: | "Jan Beulich" <JBeulich@xxxxxxxxxx> |
| Date: | Thu, 12 Aug 2010 11:07:54 +0100 |
| Cc: | xen-devel@xxxxxxxxxxxxxxxxxxx |
| Delivery-date: | Thu, 12 Aug 2010 03:07:54 -0700 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <201008121122.36706.Christoph.Egger@xxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| References: | <201008121122.36706.Christoph.Egger@xxxxxxx> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
>>> On 12.08.10 at 11:22, Christoph Egger <Christoph.Egger@xxxxxxx> wrote: > In svm_vmexit_do_pause() update the instruction pointer. > This fixes strange PAUSE intercepts on UP guests. This won't work when the instruction needs to actually be decoded: __get_instruction_length_from_list() strips all prefix bytes from the byte stream being decoded, and since 'pause' uses a prefix the actual opcode comparison will never produce a match. Even in the case that CPUs supporting the pause filter would always support nextrip I think that the special case minimally deserves a code comment to that effect, but perhaps even warrants an ASSERT() or BUG_ON(). Jan _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [Xen-devel] [xen-4.0-testing test] 1993: tolerable FAIL - PUSHED, xen . org |
|---|---|
| Next by Date: | [Xen-devel] failed to start centos 5 domU with maxmem=30000, Vasiliy G Tolstov |
| Previous by Thread: | [Xen-devel] [PATCH] xen svm: fix PAUSE instruction intercept, Christoph Egger |
| Next by Thread: | Re: [Xen-devel] [PATCH] xen svm: fix PAUSE instruction intercept, Christoph Egger |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
