| |
|
 |
|
 |
|
|
|
| |
|
|
xen-devel
Re: [Xen-devel] [PATCH] xenoprof: Cleanup
On 10/08/2010 16:55, "Ian Jackson" <Ian.Jackson@xxxxxxxxxxxxx> wrote:
> KUWAMURA Shin'ya writes ("[Xen-devel] [PATCH] xenoprof: Cleanup"):
>> The declaration of ibs_caps also exists in xen/include/asm-x86/xenoprof.h.
> ...
>> -/* AMD IBS support */
>> -extern u32 ibs_caps;
>
> But, in xen/common/xenoprof.c, surely this should be a definition and
> not a declaration. So more correct would be
>
> -extern u32 ibs_caps;
> +u32 ibs_caps;
>
> but that would conflict with the #define in
> xen/include/asm-ia64/xenoprof.h. So I'm not sure this fix is complete.
It's defined in arch-specific arch/x86/oprofile/op_model_athlon.c. Exposed
to common/xenoprof.c in the arch-specific include/asm-x86/xenoprof.h (and
stubbed out in ia64's equivalent header).
-- Keir
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
| |
|
Home