| |
|
 |
|
 |
|
|
|
| |
|
|
xen-devel
RE: [Xen-devel] [PATCH4/6] cpuidle: remove hpet access in hpet_broadcast
|
To: |
Jan Beulich <JBeulich@xxxxxxxxxx> |
|
Subject: |
RE: [Xen-devel] [PATCH4/6] cpuidle: remove hpet access in hpet_broadcast_exit |
|
From: |
"Wei, Gang" <gang.wei@xxxxxxxxx> |
|
Date: |
Thu, 17 Jun 2010 16:52:17 +0800 |
|
Accept-language: |
zh-CN, en-US |
|
Acceptlanguage: |
zh-CN, en-US |
|
Cc: |
"xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Keir Fraser <keir.fraser@xxxxxxxxxxxxx>, "Wei, Gang" <gang.wei@xxxxxxxxx> |
|
Delivery-date: |
Thu, 17 Jun 2010 01:53:47 -0700 |
|
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxxx |
|
In-reply-to: |
<4C19F83F0200007800006E0B@xxxxxxxxxxxxxxxxxx> |
|
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
|
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
|
List-post: |
<mailto:xen-devel@lists.xensource.com> |
|
List-subscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
|
List-unsubscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
|
References: |
<F26D193E20BBDC42A43B611D1BDEDE710F70FB865C@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <4C19F83F0200007800006E0B@xxxxxxxxxxxxxxxxxx> |
|
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
|
Thread-index: |
AcsN9r4eVKereB/yRmuhSCrD08xL0wAAsqXw |
|
Thread-topic: |
[Xen-devel] [PATCH4/6] cpuidle: remove hpet access in hpet_broadcast_exit |
On Thursday, 2010-6-17 4:26 PM, Jan Beulich wrote:
>>>> On 17.06.10 at 09:38, "Wei, Gang" <gang.wei@xxxxxxxxx> wrote:
>> BTW, move the cpumask set out of critial section in
>> hpet_broadcast_enter to shorten it.
>
> Could you explain why you can move it out of the locked section for
> _enter(), but can't for _exit() - this isn't obvious to me (and would
> perhaps deserve a comment in the sources).
Keeping cpumask clear within the locked section in _exit() to avoid
handle_hpet_broadcast() to access other cpu's timer_deadline_start/end after
the other cpu's mask was cleared. For set, there are no such issue. And cpumask
set/clear it self should be atom type.
Jimmy
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
| |
|
Home