WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] Re: [PATCH] Qemu: Add sanity check for vcpu config

To: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>, Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Subject: RE: [Xen-devel] Re: [PATCH] Qemu: Add sanity check for vcpu config
From: "Liu, Jinsong" <jinsong.liu@xxxxxxxxx>
Date: Tue, 23 Mar 2010 10:17:55 +0800
Accept-language: en-US
Acceptlanguage: en-US
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Mon, 22 Mar 2010 19:19:58 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <19367.42794.784069.180640@xxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <EB8593BCECAB3D40A8248BE0B6400A3846520405@xxxxxxxxxxxxxxxxxxxxxxxxxxxxx> <C7CC04CA.D6D5%keir.fraser@xxxxxxxxxxxxx> <19367.42794.784069.180640@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcrJ5Di2+HuKSqPyTxWwE8AL9oXn0wAScLvw
Thread-topic: [Xen-devel] Re: [PATCH] Qemu: Add sanity check for vcpu config
Keir,

Have you decided where should vcpu sanity check be located?
We add vcpu sanity check at qemu because:
1. xen/qemu itself has knowledge like HVM_MAX_VCPUS, xend doesn't have such 
knowledge;
2. there are many ways to transfer config/cmdline para to qemu, xm/xend is one 
of them which used at Xen. On other system like KVM, there is no xm/xend at 
all. So naturely qemu is a better place to do sanity check than xend;
3. even if we add sanity check at xend, qemu still need do sanity check. After 
all, qemu cannot totally trust its input;

Thanks,
Jinsong

Ian Jackson wrote:
> Keir Fraser writes ("[Xen-devel] Re: [PATCH] Qemu: Add sanity check
> for vcpu config"): 
>> Wouldn't xend be a more sensible place to do the check? It can
>> certainly result in a better error message, I would have thought.
> 
> Quite so.  If you add feature to xend, it should be changed in libxl
> too.
> 
> Ian.
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel