WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] gnttab: propagate Reserved flag from old to new

To: "Ian Campbell" <ian.campbell@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] gnttab: propagate Reserved flag from old to new page in gnttab_copy_grant_page.
From: "Jan Beulich" <JBeulich@xxxxxxxxxx>
Date: Tue, 23 Feb 2010 17:04:22 +0000
Cc: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Delivery-date: Tue, 23 Feb 2010 09:05:07 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1266943218-16666-1-git-send-email-ian.campbell@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1266943189.11737.6457.camel@xxxxxxxxxxxxxxxxxxxxxx> <1266943218-16666-1-git-send-email-ian.campbell@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
>>> Ian Campbell <ian.campbell@xxxxxxxxxx> 23.02.10 17:40 >>>
>--- a/drivers/xen/grant-table.c
>+++ b/drivers/xen/grant-table.c
>@@ -558,9 +558,12 @@ int gnttab_copy_grant_page(grant_ref_t ref, struct page 
>**pagep)
>       new_page->mapping = page->mapping;
>       new_page->index = page->index;
>       set_bit(PG_foreign, &new_page->flags);
>+      if (PageReserved(page))
>+              set_bit(PG_reserved, &new_page->flags);

Why not SetPageReserved()?

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel