WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] paging_domctl() missing break statements?

To: Dan Magenheimer <dan.magenheimer@xxxxxxxxxx>
Subject: Re: [Xen-devel] paging_domctl() missing break statements?
From: Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Date: Wed, 17 Feb 2010 17:36:43 +0000
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxxxx>
Delivery-date: Wed, 17 Feb 2010 09:37:16 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <facd6b51-45b6-4b05-bd41-9a3403ea751d@default>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20100217095806.GK368@xxxxxxxxxxxxxxxxxxxxxxx> <facd6b51-45b6-4b05-bd41-9a3403ea751d@default>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.18 (2008-05-17)
At 15:20 +0000 on 17 Feb (1266420027), Dan Magenheimer wrote:
> /me wonders if this explains the periodic but apparently harmless
> messages I often see on the console like:
> 
> (XEN) paging.c:170: paging_free_log_dirty_bitmap: used X pages for domain Y 
> dirty logging
> 
> which I've never reported.

No, that's just some unrelated noise; I think it went in when the
log-dirty bitmaps were made sparse. 

> And, if not, is that message useful/meaningful to anyone or
> should it be removed?

It should be removed.

Signed-off-by: Tim Deegan <Tim.Deegan@xxxxxxxxxx>

diff -r 560277d2fd20 xen/arch/x86/mm/paging.c
--- a/xen/arch/x86/mm/paging.c  Mon Feb 15 08:19:07 2010 +0000
+++ b/xen/arch/x86/mm/paging.c  Wed Feb 17 17:32:02 2010 +0000
@@ -165,9 +165,6 @@
 
     if ( !mfn_valid(d->arch.paging.log_dirty.top) )
         return;
-
-    dprintk(XENLOG_DEBUG, "%s: used %d pages for domain %d dirty logging\n",
-            __FUNCTION__, d->arch.paging.log_dirty.allocs, d->domain_id);
 
     l4 = map_domain_page(mfn_x(d->arch.paging.log_dirty.top));
 
 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>