WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 0 of 4] aio event fd support to blktap2

To: Pasi Kärkkäinen <pasik@xxxxxx>
Subject: Re: [Xen-devel] [PATCH 0 of 4] aio event fd support to blktap2
From: Daniel Stodden <daniel.stodden@xxxxxxxxxx>
Date: Fri, 29 Jan 2010 02:27:57 -0800
Cc: Xen <xen-devel@xxxxxxxxxxxxxxxxxxx>, Keir Fraser <Keir.Fraser@xxxxxxxxxxxxx>
Delivery-date: Fri, 29 Jan 2010 02:28:18 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20100129100634.GK2861@xxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Citrix VMD
References: <C7885260.80A4%keir.fraser@xxxxxxxxxxxxx> <1264756970.3295.41.camel@xxxxxxxxxxxxxxxxxxx> <20100129100634.GK2861@xxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Fri, 2010-01-29 at 05:06 -0500, Pasi Kärkkäinen wrote:
> On Fri, Jan 29, 2010 at 01:22:50AM -0800, Daniel Stodden wrote:
> > On Fri, 2010-01-29 at 03:52 -0500, Keir Fraser wrote:
> > > On 29/01/2010 08:45, "Daniel Stodden" <daniel.stodden@xxxxxxxxxx> wrote:
> > > 
> > > > On Fri, 2010-01-29 at 03:29 -0500, Daniel Stodden wrote:
> > > >> On Fri, 2010-01-29 at 03:09 -0500, Keir Fraser wrote:
> > > >>> Echo the changeset comment and sign-off into the email body would be 
> > > >>> better,
> > > >>> but your re-send is fine as far as I'm concerned. I should be able to 
> > > >>> apply
> > > >>> the attachments no problem.
> > > >> 
> > > >> Patchbomb as of hg 1.3.1 doesn't seem to do this.
> > > > 
> > > > Ah, it does.
> > > > 
> > > > So --inline implies --attach,
> > > > but is still different from --inline *and* --attach.
> > > > 
> > > > Sorry for the noise.
> > > 
> > > By the way, attaching and inlining a whole patch is also acceptable. Some
> > > people like inline patches, so that they can easily review and comment. I
> > > like attachments because they JustWork when I'm trying to apply big 
> > > bundles
> > > of patches.
> > 
> > To avoid confusion: By inline I meant the content-disposition. The
> > visual results would combine the best of both. But I suspect the results
> > somwhat depend on the mailer in use.
> > 
> > It's completely up to you. I don't charge for python cycles. :)
> > 
> > So far I got
> > 
> > [alias]
> > email-xen  = email --attach --inline --to 'Xen 
> > <xen-devel@xxxxxxxxxxxxxxxxxxx>'
> > email-xapi = email --review --inline --to 'Xen API 
> > <xen-api@xxxxxxxxxxxxxxxxxxx>'
> > 
> > Maybe Pasi knows a decent corner on the wiki where this stuff can
> > converge to gatekeeper preferences.
> > 
> 
> There's a note about submitting patches in:
> http://wiki.xensource.com/xenwiki/XenFaq
> 
> I can add this stuff there.
> 
> So those aliases should go to .hgrc ?

May. It's just a neat way to not memorize them, so I guess it might
help.

I remember a xensource wiki page where the preferred format for xapi-dev
was documented. I send you a copy when I'm back at work.

That took a patch to patchbomb though. I pasted the one I'm presently
running below.

Not sure: I think there's already a fair number xen-devel people looking
into XCP. But is Xapi-related stuff even wanted on the current wiki?

Daniel

diff -r 13e59a0b3485 -r c60348153509 patchbomb.py
--- a/patchbomb.py      Fri Jan 29 00:20:30 2010 -0800
+++ b/patchbomb.py      Fri Jan 29 00:49:13 2010 -0800
@@ -126,6 +126,9 @@
                 'Patch subject is complete summary.')
         body += '\n\n\n'
 
+    if opts.get('review'):
+        body += '\n'.join(patch)
+
     if opts.get('plain'):
         while patch and patch[0].startswith('# '):
             patch.pop(0)
@@ -494,6 +497,7 @@
           ('', 'bundlename', 'bundle',
            _('name of the bundle attachment file')),
           ('r', 'rev', [], _('a revision to send')),
+          ('R', 'review', None, _('add patch to message body for review')),
           ('', 'force', None,
            _('run even when remote repository is unrelated '
              '(with -b/--bundle)')),





_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel