Re: [Xen-devel] [PATCH] evtchn_do_upcall: Fix logic to start cor

I don't see changeset linux-2.6.18-xen:988. I agree pre-incrementing is better. 
I am fine as long as the code is fixed.

-Kaushik

On Jan 29, 2010, at 2:43 AM, Keir Fraser wrote:

> On 29/01/2010 05:34, "Kaushik Kumar Ram" <kaushik@xxxxxxxx> wrote:
> 
>> # HG changeset patch
>> # User kaushik
>> # Date 1264742860 21600
>> # Node ID de3e05e5eec28aa332ae1aa35a2edf97ded769f5
>> # Parent  91224343eeee460c9aafdaadc1bdedab54e92256
>> Fix the logic to start correctly at "last processed port + 1" in
>> evtchn_do_upcall.
>> 
>> Signed-off-by: Kaushik Kumar Ram <kaushik@xxxxxxxx>
> 
> Take a look at linux-2.6.18-xen:988, which is a (significant)
> reinterpretation of your patch. I think some confusion and bugs arise from
> pre-incrementing the loop indexes, so I changed back to post-incrementing as
> we used to do. I think the code is a fair bit clearer. Hopefully it also
> works just as well!
> 
> Thanks,
> Keir
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel
> 


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread]

Current Thread

[Next in Thread>

Previous by Date:

Re: [Xen-devel] [PATCH 0 of 4] aio event fd support to blktap2, Keir Fraser

Next by Date:

Re: [Xen-devel] [PATCH 0 of 4] aio event fd support to blktap2, Daniel Stodden

Previous by Thread:

Re: [Xen-devel] [PATCH] evtchn_do_upcall: Fix logic to start correctly at "last processed port + 1", Keir Fraser

Next by Thread:

Re: [Xen-devel] [PATCH] evtchn_do_upcall: Fix logic to start correctly at "last processed port + 1", Keir Fraser

Indexes:

[Date] [Thread] [Top] [All Lists]