WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH 0/6 ] MCE: patches clean-up and fixing bugs

To: "Jiang, Yunhong" <yunhong.jiang@xxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH 0/6 ] MCE: patches clean-up and fixing bugs
From: Frank Van Der Linden <Frank.Vanderlinden@xxxxxxx>
Date: Thu, 28 Jan 2010 08:37:30 -0700
Cc: Christoph Egger <Christoph.Egger@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Keir Fraser <keir.fraser@xxxxxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxxxx>
Delivery-date: Thu, 28 Jan 2010 07:38:22 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C8EDE645B81E5141A8C6B2F73FD9265117C58A3361@xxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <C8EDE645B81E5141A8C6B2F73FD9265117C58A3361@xxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird 2.0.0.23 (Macintosh/20090812)
Jiang, Yunhong wrote:
This series patches clean-up and fixing some bugs for MCE handler. Most of them 
are quite minor, except the vmsr.patch.

Patch 1: bank.patch: Handle the virtual MCE MSR bank access correctly.

Patch 2: vmsr.patch: Not GP fault when guest write non 0s or 1s to MCA CTL MSRs.

Patch 3: put_domain.patch: put domain in mce action.

Patch 4: mca_add_trans.patch: Fix the vMCE address translation for HVM guest.

Patch 5: broadcast.patch: Add MCE broadcast checkiing.

Patch 6: mce_printk.patch: Be more careful for printk in mce context.

Thanks for the patches! Aside from the comments Christoph already made, these look good to me. Thanks for also including the mce_is_broadcast part, that fixes injection on NHM-EX.

It would be good to re-integrate the mcheck handler for AMD and Intel, but as you said, you have a patch lined up for that, and that can be done in the future.

- Frank


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>