This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] VT-d: improve RMRR validity checking

To: keir.fraser@xxxxxxxxxxxxx
Subject: Re: [Xen-devel] [PATCH] VT-d: improve RMRR validity checking
From: Noboru Iwamatsu <n_iwamatsu@xxxxxxxxxxxxxx>
Date: Fri, 22 Jan 2010 10:35:45 +0900
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, weidong.han@xxxxxxxxx
Delivery-date: Thu, 21 Jan 2010 17:36:33 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C77E1D66.6FF7%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <C77E1D66.6FF7%keir.fraser@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; ja; rv: Gecko/20100111 Thunderbird/3.0.1

I re-send the DRHD-fix patch.

If DRHD does not have existent devices, ignore it.
If DRHD has both existent and non-existent devices, consider it invalid
and not register.

What happens if you register a DRHD with some but not all devices existing?
Do bad things happen on some systems?

In the case I have posted the log, DRHD has only non-existent devices,
and maybe its info is invalid. So iommu_enable_translation() failed and
became panic.

When DRHD has at least one existent device, I have not seen,
its info might be correct. I cannot judge it, so disabled at the patch.

Even if this DRHD-ignore patch is not accepted, we should validate the
DRHD and stop the PANIC.

Xen-devel mailing list