WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH] numa: fix problems with memory-less nodes

To: Andre Przywara <andre.przywara@xxxxxxx>
Subject: [Xen-devel] Re: [PATCH] numa: fix problems with memory-less nodes
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Wed, 13 Jan 2010 09:55:59 +0000
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 13 Jan 2010 01:56:23 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4B4D9582.5010806@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcqUNM0WupdflBsiRiGQk6DnNkGcUwAAc5Qq
Thread-topic: [PATCH] numa: fix problems with memory-less nodes
User-agent: Microsoft-Entourage/12.23.0.091001
On 13/01/2010 09:42, "Andre Przywara" <andre.przywara@xxxxxxx> wrote:

> To be honest I am not a fan of omitting nodes from physinfo, but that is
> what the current code (RC1!) does and it definitely breaks Xen on my
> box. So I just made this small patch to make it work again.
> Actually I would opt to revert the patch cropping the number of nodes
> reported by physinfo (20762:a1d0a575b4ba ?). Yes, that would result in
> nodes reported with zero memory, but in my tests this did not raise
> problems, as a node's memory can (and will) be exhausted even during
> normal operation.

The intention of 20762 was not to change the semantics of the node_to_*
lists. It's simply supposed to make available max_node_id to the toolstack
(since this can differ from nr_nodes if there are holes in the online node
map).

If the node_to_* semantics really have been changed by 20762, then it is a
bug. It's not a bug I can eyeball however.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel