 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH][TOOLS] blktap: make memshr optional
| To: | Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>, Christoph Egger <Christoph.Egger@xxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH][TOOLS] blktap: make memshr optional |
| From: | Keir Fraser <keir.fraser@xxxxxxxxxxxxx> |
| Date: | Tue, 12 Jan 2010 17:41:54 +0000 |
| Cc: | "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx> |
| Delivery-date: | Tue, 12 Jan 2010 09:42:17 -0800 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <19276.45320.957868.768458@xxxxxxxxxxxxxxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | AcqTrJoMgMOTL4rdSzeTKMTW90IRMAAAe1vF |
| Thread-topic: | [Xen-devel] [PATCH][TOOLS] blktap: make memshr optional |
| User-agent: | Microsoft-Entourage/12.23.0.091001 |
On 12/01/2010 17:27, "Ian Jackson" <Ian.Jackson@xxxxxxxxxxxxx> wrote:
> Christoph Egger writes ("[Xen-devel] [PATCH][TOOLS] blktap: make memshr
> optional"):
>> Attached patch makes memshr optional for blktap/blktap2.
>> This fixes build for platforms where memshr isn't build on.
>
> That and ...
>
>> While there, make indentation consistent.
>
> ... this should be separated out, surely.
>
> Mixing up a whitespace change with anything else is a recipe for
> making things hard to track down.
In this rare case it looked okay to me, as the whitespace changes are
exactly co-located with the patch's semantic changes. So the semantic
changes remain pretty clear in the diff.
-- Keir
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Xen-devel] build fixes, Keir Fraser |
|---|---|
| Next by Date: | Re: [Xen-devel] build fixes, Patrick Colp |
| Previous by Thread: | Re: [Xen-devel] [PATCH][TOOLS] blktap: make memshr optional, Ian Jackson |
| Next by Thread: | [Xen-devel] [PATCH 0/6] libxl last fixups, Vincent Hanquez |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
