WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] Handle PoD case in hvm_hap_nested_page_fault()

To: George Dunlap <dunlapg@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Handle PoD case in hvm_hap_nested_page_fault()
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Wed, 06 Jan 2010 12:49:01 +0000
Cc:
Delivery-date: Wed, 06 Jan 2010 04:49:32 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <de76405a1001060419x714c215fo8b2cc1c134627ae4@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcqOypPV5FCY3ogcSIKwjwlxuw7lrwABArXU
Thread-topic: [Xen-devel] [PATCH] Handle PoD case in hvm_hap_nested_page_fault()
User-agent: Microsoft-Entourage/12.23.0.091001
I checked in a different version as c/s 20763: take a look. It's
questionable whether returning 0 from the function is ever a sensible thing.
I suppose at least this way we have to have considered all cases properly.
At least I think we won't change it during the 4.0.0 freeze.

 -- Keir

On 06/01/2010 12:19, "George Dunlap" <dunlapg@xxxxxxxxx> wrote:

> The new combined nested page fault handling doesn't consider the case
> where the gfn_to_mfn() translation caused the page to be transparently
> populated.  Attached patch is one solution; a more robust solution
> would be to take the access type (read or write) and check it against
> the type returned by gfn_to_mfn() to handle spurious NPFs as well (if
> such things ever happen).
> 
> Signed-off-by: George Dunlap <george.dunlap@xxxxxxxxxxxxx>



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>